Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force typing and remove unused typeless serialization #769

Merged
merged 6 commits into from
Jul 25, 2024
Merged

force typing and remove unused typeless serialization #769

merged 6 commits into from
Jul 25, 2024

Conversation

Jacob-Eliat-Eliat
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (326b2e9) to head (757d85e).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   84.48%   84.54%   +0.05%     
==========================================
  Files          96       96              
  Lines        2772     2666     -106     
  Branches      199      184      -15     
==========================================
- Hits         2342     2254      -88     
+ Misses        430      412      -18
Files Coverage Δ
...scala/v1/fdm/instances/InstancePropertyValue.scala 100.00% <ø> (+14.06%) ⬆️
.../sdk/scala/v1/fdm/instances/NodeOrEdgeCreate.scala 100.00% <ø> (+14.28%) ⬆️
...k/scala/v1/resources/fdm/instances/instances.scala 84.31% <ø> (-0.31%) ⬇️
...dk/scala/v1/fdm/instances/InstanceDefinition.scala 75.97% <0.00%> (-2.10%) ⬇️

@Jacob-Eliat-Eliat Jacob-Eliat-Eliat marked this pull request as ready for review July 25, 2024 12:47
@github-actions github-actions bot requested a review from mr-celo July 25, 2024 12:47
@Jacob-Eliat-Eliat Jacob-Eliat-Eliat merged commit 72cc873 into master Jul 25, 2024
8 checks passed
@Jacob-Eliat-Eliat Jacob-Eliat-Eliat deleted the force-typing-and-remove-typeless-serdeser branch July 25, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvavelosa silvavelosa silvavelosa approved these changes

@larshagencognite larshagencognite Awaiting requested review from larshagencognite larshagencognite is a code owner

@VerstraeteBert VerstraeteBert Awaiting requested review from VerstraeteBert VerstraeteBert is a code owner automatically assigned from cognitedata/r-alliance

@mr-celo mr-celo Awaiting requested review from mr-celo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jacob-Eliat-Eliat @silvavelosa