Drop NoAuthentication Auth implementation #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It throws upon use so isn't very useful, removing it makes sticking to making illegal states unrepresentable easier, also just a cleanup of unused code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 84.62% 84.65% +0.03%
==========================================
Files 96 96
Lines 2679 2678 -1
Branches 195 229 +34
==========================================
Hits 2267 2267
+ Misses 412 411 -1
|
|
This pull request seems a bit stale.. Shall we invite more to the party? |
Jacob-Eliat-Eliat
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It throws upon use so isn't very useful, removing it makes sticking
to making illegal states unrepresentable easier, also just a cleanup
of unused code.