Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scalastyle plugin #737

Merged
merged 2 commits into from
Jul 3, 2024
Merged

remove scalastyle plugin #737

merged 2 commits into from
Jul 3, 2024

Conversation

larshagencognite
Copy link
Contributor

scalastyle is abandoned for +5 years, and is making it difficult to maintain updates

scalastyle is abandoned for +5 years, and is making it difficult to maintain updates
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.12%. Comparing base (6d308a4) to head (c72464e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files          99       99           
  Lines        2881     2881           
  Branches       29       29           
=======================================
  Hits         2366     2366           
  Misses        515      515           
Files Coverage Δ
...in/scala/com/cognite/sdk/scala/common/OAuth2.scala 91.30% <ø> (ø)
...in/scala/com/cognite/sdk/scala/common/filter.scala 82.35% <ø> (ø)
...c/main/scala/com/cognite/sdk/scala/v1/Client.scala 82.27% <ø> (ø)
...com/cognite/sdk/scala/v1/dataModelProperties.scala 10.20% <ø> (ø)
.../v1/fdm/common/properties/PropertyDefinition.scala 87.50% <ø> (ø)
...dk/scala/v1/fdm/instances/InstanceDefinition.scala 77.77% <ø> (ø)
...n/scala/com/cognite/sdk/scala/v1/propertyMap.scala 0.00% <ø> (ø)
...om/cognite/sdk/scala/v1/resources/dataPoints.scala 93.14% <ø> (ø)
...scala/com/cognite/sdk/scala/common/dataTypes.scala 83.92% <75.00%> (ø)

Copy link

This pull request seems a bit stale.. Shall we invite more to the party?

@github-actions github-actions bot added the Stale label Jun 21, 2024
Copy link
Contributor

@dmivankov dmivankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop, some replacement linters or formatters could be looked into but there's already wartremover and scalafmt configured in this repo, so at least something is still in place

@dmivankov dmivankov merged commit 2fe95e9 into master Jul 3, 2024
6 checks passed
@dmivankov dmivankov deleted the remove_scalastyle branch July 3, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants