Update scala SDK to support inlined views in sync #728

kornelione · 2024-03-11T10:18:27Z

ensures correct decoding of json

codecov · 2024-03-11T10:34:03Z

Codecov Report

Merging #728 (9c366e6) into master (ef0b683) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   81.15%   81.21%   +0.05%     
==========================================
  Files          95       95              
  Lines        2823     2832       +9     
  Branches       26       29       +3     
==========================================
+ Hits         2291     2300       +9     
  Misses        532      532

Files	Coverage Δ
...dk/scala/v1/fdm/instances/InstanceDefinition.scala	`73.29% <ø> (ø)`
.../scala/v1/fdm/instances/InstanceSyncResponse.scala	`100.00% <100.00%> (ø)`

src/main/scala/com/cognite/sdk/scala/v1/fdm/instances/InstanceSyncResponse.scala

CDF-21121: Update scala SDK to support inlined views in sync

3328b37

kornelione requested a review from a team as a code owner March 11, 2024 10:18

kornelione had a problem deploying to CI March 11, 2024 10:18 — with GitHub Actions Failure

kornelione temporarily deployed to CI March 11, 2024 10:18 — with GitHub Actions Inactive

github-actions bot requested a review from dmivankov March 11, 2024 10:18

fix sbt test:scalastyle issues

fb92510

kornelione temporarily deployed to CI March 11, 2024 10:29 — with GitHub Actions Inactive

dmivankov reviewed Mar 11, 2024

View reviewed changes

src/main/scala/com/cognite/sdk/scala/v1/fdm/instances/InstanceSyncResponse.scala Show resolved Hide resolved

dmivankov reviewed Mar 11, 2024

View reviewed changes

src/main/scala/com/cognite/sdk/scala/v1/fdm/instances/InstanceSyncResponse.scala Show resolved Hide resolved

bubble up parse errors via traverse

cc5d618

dmivankov temporarily deployed to CI March 11, 2024 12:25 — with GitHub Actions Inactive

dmivankov had a problem deploying to CI March 11, 2024 12:25 — with GitHub Actions Failure

dmivankov temporarily deployed to CI March 11, 2024 12:25 — with GitHub Actions Inactive

bump minor version just in case of behavior changes

8f2a447

dmivankov approved these changes Mar 11, 2024

View reviewed changes

dmivankov had a problem deploying to CI March 11, 2024 12:28 — with GitHub Actions Failure

dmivankov temporarily deployed to CI March 11, 2024 12:28 — with GitHub Actions Inactive

scala 2.12 compat

9c366e6

dmivankov had a problem deploying to CI March 11, 2024 12:54 — with GitHub Actions Failure

dmivankov temporarily deployed to CI March 11, 2024 12:54 — with GitHub Actions Inactive

dmivankov temporarily deployed to CI March 11, 2024 13:03 — with GitHub Actions Inactive

kornelione merged commit f320556 into master Mar 11, 2024
6 checks passed

kornelione deleted the include_typing_in_sync branch March 11, 2024 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update scala SDK to support inlined views in sync #728

Update scala SDK to support inlined views in sync #728

kornelione commented Mar 11, 2024

codecov bot commented Mar 11, 2024 •

edited

Loading

Update scala SDK to support inlined views in sync #728

Update scala SDK to support inlined views in sync #728

Conversation

kornelione commented Mar 11, 2024

codecov bot commented Mar 11, 2024 • edited Loading

Codecov Report

codecov bot commented Mar 11, 2024 •

edited

Loading