Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Gymnasium Tuple Space #20

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Support for Gymnasium Tuple Space #20

merged 5 commits into from
Apr 10, 2024

Conversation

wduguay-air
Copy link
Contributor

Description

Add serialization support for spaces of type gymnasium.spaces.Tuple.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wduguay-air wduguay-air requested a review from RedTachyon April 3, 2024 15:25
@wduguay-air wduguay-air self-assigned this Apr 3, 2024
wduguay-air
wduguay-air commented Apr 3, 2024
View reviewed changes
cogment_lab/generated/cog_settings.py Outdated
@@ -1,17 +1,3 @@
# Copyright 2024 AI Redefined Inc. <[email protected]>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this was removed by pre-commit...

wduguay-air
wduguay-air commented Apr 3, 2024
View reviewed changes
tests/test_spaces_serialization.py Outdated
@@ -0,0 +1,89 @@
# Copyright 2023 AI Redefined Inc. <[email protected]>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was present in cogment-verse. I just added the Tuple in it.

@RedTachyon RedTachyon merged commit 651854a into develop Apr 10, 2024
7 checks passed
@RedTachyon RedTachyon deleted the support-gymnasium-tuple branch April 10, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedTachyon RedTachyon Awaiting requested review from RedTachyon

Assignees

@wduguay-air wduguay-air

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wduguay-air @RedTachyon