Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue #2495 #2664

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: issue #2495 #2664

wants to merge 1 commit into from
+9 −3

Conversation

michalismeng
Copy link

Fix issue #2495.

Changes:

  • Add a default block only when a placeholder is defined.
  • In renderer, inserting an empty block when zero blocks are given, results in an extra block being rendered. In readonly mode this is empty. Fix this behavior.

Outcome of this PR:

  • Display the placeholder text, only if defined (whether in readonly mode or not).
  • Do not add an extra empty paragraph in readonly mode.

@michalismeng
fix(readonly): Honor placeholder in readonly mode
930f59f 
When in readonly mode, render the placeholder only if it is defined.

In addition, do not add an extra default block. Update initialization.cy.ts
accordingly for this case.
@timsun28 timsun28 mentioned this pull request May 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc Awaiting requested review from neSpecc neSpecc is a code owner

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina TatianaFomina is a code owner

@ilyamore88 ilyamore88 Awaiting requested review from ilyamore88 ilyamore88 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michalismeng