[dale] - Step5 리턴타입 class -> protocol 변경 #92
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // | ||
| // PhotoRectangle.swift | ||
| // DrawingApp | ||
| // | ||
| // Created by dale on 2022/03/16. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| class PhotoRectangle: Shape{ | ||
| var backgroundImage: Data | ||
|
|
||
| init(size: Size, position: Position, imageData: Data, alpha: Alpha) { | ||
| self.backgroundImage = imageData | ||
| super.init(size: size, position: position, alpha: alpha) | ||
| } | ||
| } | ||
|
|
||
| extension PhotoRectangle : CustomStringConvertible{ | ||
| var description: String { | ||
| return "(\(self.id)), \(position), \(self.size), \(self.backgroundImage) , \(self.alpha)" | ||
|
There was a problem hiding this comment. Data 타입은 이렇게 description을 하는게 큰 의미는 없습니다. 존재하는지 혹은 크기가 바뀌는지 정도만 봐도 다행이죠 |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // | ||
| // ViewObject.swift | ||
| // DrawingApp | ||
| // | ||
| // Created by dale on 2022/03/16. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| class Shape{ | ||
| private(set) var id : Id = Id() | ||
| private(set) var size : Size | ||
| private(set) var position : Position | ||
| private(set) var alpha : Alpha | ||
|
|
||
| init(size: Size, position : Position, alpha : Alpha) { | ||
| self.size = size | ||
| self.position = position | ||
| self.alpha = alpha | ||
| } | ||
|
|
||
| func setAlpha(to alpha: Alpha) { | ||
| self.alpha = alpha | ||
| } | ||
| } | ||
|
|
||
| extension Shape: Equatable, Hashable { | ||
|
Comment on lines
+10
to
+27
There was a problem hiding this comment. 어.. Shape가 프로토콜인 줄 알았는데 상위 클래스였네요. 상위 클래스가 있어도 되는데 프로토콜로 추상화할 부분도 시도해보세요. |
||
| static func == (lhs: Shape, rhs: Shape) -> Bool { | ||
| return ObjectIdentifier(lhs) == ObjectIdentifier(rhs) | ||
|
There was a problem hiding this comment. Shape 객체가 같다는 어떤 의미가 있을까요? https://lucas.codesquad.kr/masters-2022/course/모바일-iOS-클래스/포커게임-앱/카드덱-구현하고-테스트하기 에 참고자료로 올라온 내용 중에 Identity와 Equality를 다시 확인해보세요. 그래서 질문은 == 연산으로 무엇을 비교하려고 하는 것인가, 그 의도가 중요한 것 같습니다. class 경우는 === 연산도 있는데 어떤 역할을 하려는 것인가 궁금합니다. There was a problem hiding this comment. 처음 설계 당시에는 b와 같이 모든 속성이 동일하면 같다 라고 판단을 하였는데, 아주 적은 확률이라도 겹칠경우가 있어 두 도형의 참조값을 비교하는게 확실한 방법같아서 === 와 Objectidentifier사이에서 고민하게 되었습니다. |
||
| } | ||
|
|
||
| func hash(into hasher: inout Hasher) { | ||
| hasher.combine(id) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
항상 속성은 private var를 우선적으로 고려하세요