mariadb (sorry): fix missing pthread mutex init after calloc #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added conditional dependency to rpm spec
Conflicts: galera/tests/certification_check.cpp galera/tests/ist_check.cpp gcs/src/unit_tests/gcs_core_test.cpp
- Free Page pointers in PageStore page queue in PageStore destructor. - Fixed buffer overflow errors in gcache_page_test.cpp.
Conflicts: galera/src/saved_state.cpp galera/tests/certification_check.cpp galera/tests/service_thd_check.cpp gcs/src/unit_tests/gcs_core_test.cpp gcs/src/unit_tests/gcs_defrag_test.cpp gcs/src/unit_tests/gcs_test_utils.cpp
* galera-custom-boost: galera-bugs #913
The building of RPMs assumes the code is already built. This may have been done with CMake. Having the build depends here can fail if scons isn't installed, despite is never used.
Sometime platform compilers are needed like: MariaDB/buildbot#190
Detection is just for the detection of sles. Remove other RPM distros.
Use this where the distro cannot be queried with rpm.
From /etc/SuSE-release
SUSE Linux Enterprise Server 12 (s390x)
VERSION = 12
PATCHLEVEL = 5
# This file is deprecated and will be removed in a future service pack or release.
# Please check /etc/os-release for details about this release.
On SLES12:
rpm --eval '%{dist}'
%{dist}
/etc/os-release
NAME="SLES"
VERSION="12-SP5"
VERSION_ID="12.5"
PRETTY_NAME="SUSE Linux Enterprise Server 12 SP5"
ID="sles"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:suse:sles:12:sp5"
So we use NAME/ID/VERSION_ID to form the required distro tag.
4.ee-failed-report-last-committed
improved diagnotics.
Conflicts: galera/src/galera-sym.map galera/src/trx_handle.hpp galera/src/wsrep_provider.cpp galera/tests/certification_check.cpp gcs/src/gcs_group.cpp
The common bits of rpm -qi --provides for: * libopenssl-devel * libopenssl-3-devel * libopenssl-1_1-devel are: pkgconfig(libcrypto) pkgconfig(libopenssl) pkgconfig(libssl) pkgconfig(openssl) Libssl seems the most accurate on usage.
We must read the 8-byte timeout expiration counter (using the "timerfd" descriptor) every time when an EPOLLIN event occurs. Otherwise, the timer may stop notifying the application of new events, and all actions related to this timer will be frozen on some systems; or vice versa, we will get an infinite loop of notifications due to the constant readiness to read new data.
…devel-dep sles/opensuse 15 dependency on ssl-devel
Without a /etc/os-release ID and VERSION_ID would be blank, so lets just populate these with an unknown tag.
build: empty /etc/os-release
calls constructor for a mutex in a struct value init-ed with gu_calloc. in path `gcs_core_create() -> gcs_group_init()`, the first one allocates `gcs_core_t* core` with gu_calloc() whereas `gcs_code_t` has `gcs_group_t group` with `gu::Mutex memb_mtx_`. After memory allocation gu::Mutex constructor was not called that lead to an error on Darwin in a call to pthread mutex lock. Signed-off-by: Ivan Prisyazhnyy <[email protected]>
sitano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... this is actual only for mariadb version ...