Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dropdown of events to navbar #205

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Afonso-santos
Copy link
Contributor

@Afonso-santos Afonso-santos commented Oct 16, 2023

I add a a header events with a dropdown. In the dropdown we can choose coder camp and dojo con page.

@Afonso-santos Afonso-santos self-assigned this Oct 16, 2023
@reviewpad reviewpad bot added the blog Blog related contributions label Oct 16, 2023
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for coderdojobraga-maintenance canceled.

Name Link
🔨 Latest commit 01a621d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-maintenance/deploys/65e590ed80df4500084c30f2

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for coderdojobraga-app failed.

Name Link
🔨 Latest commit 01a621d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-app/deploys/65e590ede4d0c40008c0c271

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for coderdojobraga-web canceled.

Name Link
🔨 Latest commit 01a621d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-web/deploys/65e590ed67211500088e74b6

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for coderdojobraga-blog failed.

Name Link
🔨 Latest commit 01a621d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-blog/deploys/65e590edda715100080af64c

@reviewpad
Copy link

reviewpad bot commented Oct 16, 2023

AI-Generated Summary: This pull request includes significant changes to the codebase. Two blog posts named 'difference-languages.md' and 'tech-post-1.md' have been removed from the applications directory.

In the file 'NavBar.tsx', a 'DownOutlined' icon from 'ant-design' has been added. A new set of functionalities for events dropdown has been implemented, which will open an events dropdown menu on a click and close the userDropdown if opened. The existing userDropdown has been modified to close the events dropdown upon opening. Moreover, the appearance of the user icon has been changed to a slightly larger size.

In the 'config.ts' file, the links to 'DojoCon' and 'Coder Camp' have been removed from the main navigation bar menu and they are implemented to appear in the new events dropdown menu.

Different CSS classes have been used throughout to change the style of the elements affected by these changes. These modifications seem to be a part of an effort to improve the website's navigation by categorizing related pages under common dropdown menus and enhancing user experience.

@Afonso-santos
Copy link
Contributor Author

@ruilopesm ruilopesm changed the title feat: I add a dropdown in web pag feat: add dropdown of events to navbar Nov 25, 2023
Copy link
Member

@pedrofp4444 pedrofp4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing 2 posts from the blog?

Copy link
Member

@pedrofp4444 pedrofp4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, be careful changing the package-lock.json, is it actually needed for this PR?

Copy link
Member

@pedrofp4444 pedrofp4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lastly, your alterations should be done for mobile users too, you can follow this example of how to do it. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog Blog related contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants