-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dropdown of events to navbar #205
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for coderdojobraga-maintenance canceled.
|
❌ Deploy Preview for coderdojobraga-app failed.
|
✅ Deploy Preview for coderdojobraga-web canceled.
|
❌ Deploy Preview for coderdojobraga-blog failed.
|
AI-Generated Summary: This pull request includes significant changes to the codebase. Two blog posts named 'difference-languages.md' and 'tech-post-1.md' have been removed from the applications directory. In the file 'NavBar.tsx', a 'DownOutlined' icon from 'ant-design' has been added. A new set of functionalities for events dropdown has been implemented, which will open an events dropdown menu on a click and close the userDropdown if opened. The existing userDropdown has been modified to close the events dropdown upon opening. Moreover, the appearance of the user icon has been changed to a slightly larger size. In the 'config.ts' file, the links to 'DojoCon' and 'Coder Camp' have been removed from the main navigation bar menu and they are implemented to appear in the new events dropdown menu. Different CSS classes have been used throughout to change the style of the elements affected by these changes. These modifications seem to be a part of an effort to improve the website's navigation by categorizing related pages under common dropdown menus and enhancing user experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing 2 posts from the blog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, be careful changing the package-lock.json, is it actually needed for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly, your alterations should be done for mobile users too, you can follow this example of how to do it. 🙏
I add a a header events with a dropdown. In the dropdown we can choose coder camp and dojo con page.