Skip to content

Commit

Permalink
Disable safari compression compatability layer
Browse files Browse the repository at this point in the history
Closes #218
  • Loading branch information
nhooyr committed Apr 14, 2020
1 parent 7157c05 commit 4edcada
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions accept.go
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,9 @@ func acceptCompression(r *http.Request, w http.ResponseWriter, mode CompressionM
switch ext.name {
case "permessage-deflate":
return acceptDeflate(w, ext, mode)
case "x-webkit-deflate-frame":
return acceptWebkitDeflate(w, ext, mode)
// Disabled for now, see https://github.com/nhooyr/websocket/issues/218
// case "x-webkit-deflate-frame":
// return acceptWebkitDeflate(w, ext, mode)
}
}
return nil, nil
Expand Down
1 change: 1 addition & 0 deletions compress.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package websocket
// by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
// It will work the same in every way except that we cannot signal to the peer we
// want to use no context takeover on our side, we can only signal that they should.
// It is however currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
type CompressionMode int

const (
Expand Down

0 comments on commit 4edcada

Please sign in to comment.