Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow empty run layers to be pushed without force build meta #34

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: allow empty run layers to be pushed without force build meta #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/executor/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,11 @@ func (s *stageBuilder) takeSnapshot(files []string, shdDelete bool) (string, err
} else {
// Volumes are very weird. They get snapshotted in the next command.
files = append(files, util.Volumes()...)
snapshot, err = s.snapshotter.TakeSnapshot(files, shdDelete, s.opts.ForceBuildMetadata)
forceBuildMetadata := s.opts.ForceBuildMetadata
if s.opts.Cache && len(s.opts.Destinations) > 0 && !s.opts.NoPush {
forceBuildMetadata = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably log when we force-enable this!

}
snapshot, err = s.snapshotter.TakeSnapshot(files, shdDelete, forceBuildMetadata)
}
timing.DefaultRun.Stop(t)
return snapshot, err
Expand Down
Loading