Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Set -enable-global-offset=false #516

Merged
merged 1 commit into from
May 8, 2024
Merged

Set -enable-global-offset=false #516

merged 1 commit into from
May 8, 2024

Conversation

pgorlani
Copy link
Contributor

@pgorlani pgorlani commented May 7, 2024

This patch disables the compilation of unused/deprecated global-offset kernels.

s-Nick
s-Nick approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@s-Nick s-Nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgorlani pgorlani requested review from hjabird and Rbiessy May 7, 2024 09:19
hjabird
hjabird reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@hjabird hjabird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this all have to duplicated?

@Rbiessy
Copy link
Collaborator

Rbiessy commented May 7, 2024

Why does this all have to duplicated?

I think we don't have much choice because when building the library we want to use the PRIVATE visibility to only use the flag for portBLAS, in header-only mode this needs to the INTERFACE visibility to add this flag to anything using portBLAS.
We could consider having a helper function but I'm not sure it would help that much.

@pgorlani pgorlani merged commit 30ed01a into codeplaysoftware:master May 8, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rbiessy Rbiessy Rbiessy approved these changes

@s-Nick s-Nick s-Nick approved these changes

@hjabird hjabird hjabird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgorlani @Rbiessy @hjabird @s-Nick