This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Refactor level1 nrm2 operator #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-Nick
requested review from
mehdi-goli,
muhammad-tanvir-1211,
pgorlani,
OuadiElfarouki and
aacostadiaz
OuadiElfarouki
approved these changes
Oct 5, 2023
muhammad-tanvir-1211
approved these changes
Oct 13, 2023
The nrm2 implementation is reduction based, so now it shares the same implementation of asum with its adjustments. Preliminary update of all backend to support the newest changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the implementation of the
nrm2operator.These changes are based on the work done for
asumoperator which was merged with PR #458. Nownrm2implementation shares the same structure ofasumadjusting the execution call to its needs.Update for
nrm2each architecture backend file to manage the different kernel sizes and these numbers are set empirically using available hardware.