Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support suppressed lint message #163

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Support suppressed lint message #163

merged 6 commits into from
Mar 19, 2024

Conversation

Affankhushnod1994
Copy link
Contributor

@Affankhushnod1994 Affankhushnod1994 commented Mar 18, 2024 •
edited
Loading

  • Make Codecoach aware of SuppressedLintMessage
  • Add suppressed ESLint message to message list with severity === 0 (ignore) so codecoach doesn't comment on the MR
  • Aforementioned message needs to be queried from superset.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

encX
encX previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@encX encX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@encX encX merged commit a05ccf3 into codeleague:main Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encX encX encX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Affankhushnod1994 @encX