chore: reuse github workflows #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kenjis
force-pushed
the
reuse-ga-workflows
branch
from
926cc4b
to
cd63df8
Compare
kenjis
force-pushed
the
reuse-ga-workflows
branch
from
cd63df8
to
e742182
Compare
Arhell
approved these changes
Sep 12, 2023
MGatner
approved these changes
Sep 12, 2023
|
Why not rector.yml? Some dependency issues as Settings? |
|
Rector is not required in this repository. Lines 34 to 37 in ed010b2 |
|
We should probably change that to use our standard. The YAML is installing Rector globally but the version is way behind: ^0.15.1 Doesn't have to be part of this PR but I would like to see this consistent with our other repos. |
|
Let's update it after the new devkit release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See codeigniter4/CodeIgniter4#7819
The following is not updated: