-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use workflows in codeigniter4/.github #811
Conversation
9f4d070
to
1834262
Compare
1a2cf46
to
f249b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I always have a problem with one repo being dependent on another. However, I understand the benefits of this work for the team. You are trying to eliminate duplicate tasks.
codeigniter4/.github It seems to be public, and I assume so any repo can use this method even if it is not under organization?
Co-authored-by: Pooya Parsa <[email protected]>
Yes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I think using Rector as a non-dependency is technically better I think this ends up being cleaner and safer. I will move my own work in the same direction.
@MGatner If we don't have rector, devs cannot run rector.
Have you experienced any dependency conflicts with installing rector? |
Nope! I bought into Bergmann's strong anti-dependency sentiment for static analysis when I first created this. I'm over it 😇 This is a good change. |
See codeigniter4/CodeIgniter4#7819
phpcpd.yml
is not updated. See chore: use codeigniter4/.github/.github/workflows/phpcpd.yml #813