Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: phpstan issues #35

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix: phpstan issues #35

merged 1 commit into from
Dec 29, 2023

Conversation

michalsn
Copy link
Member

Description
This PR fixes PHPStan issues and adds more tests.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7355519679

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.365%
Totals Coverage Status
Change from base Build 7347804127: 0.0%
Covered Lines: 484
Relevant Lines: 554
💛 - Coveralls

@michalsn michalsn mentioned this pull request Dec 29, 2023
Merged
5 tasks
@michalsn michalsn merged commit d15dc13 into codeigniter4:develop Dec 29, 2023
12 checks passed
@michalsn michalsn deleted the fix/cs branch January 6, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalsn @coveralls @lonnieezell