Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add base tests for commands #27

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

michalsn
Copy link
Member

Description
This PR adds basic tests for commands.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member Author

If anyone has an idea what is going on with rector, I would appreciate any hint.

Locally everything is passing on my machine 🤷‍♂️

Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the CLITestCase might be a good test trait to add to the core....

@michalsn
Copy link
Member Author

This is rather a temporary solution. Thanks to @kenjis we already have very good Mocking for CLI: https://github.com/codeigniter4/CodeIgniter4/blob/4.5/system/Test/Mock/MockInputOutput.php, but it will be released with v4.5.

@lonnieezell
Copy link
Member

Ah, ok, nice! I missed that one.

@kenjis
Copy link
Member

kenjis commented Dec 20, 2023

@michalsn

Installing rector/rector (0.15.25): Extracting archive

The version is too old.

@michalsn michalsn merged commit b289d14 into codeigniter4:develop Dec 21, 2023
11 checks passed
@michalsn michalsn deleted the command-tests branch December 21, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants