fix: ensure all env var values are quoted #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scme0
changed the title
mikhail-klimko
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Strings are currently not quoted in the envVars sections for engine and dind pods in the helm chart. This is an issue if you put an env value in that is actually an integer or a float but put quotes around it. The helm chart will think it's a string and so leave the value unquoted which will then cause issues when the yaml is parsed inside the runner (in venona's go code).
Why
Env vars are always strings so we can wrap them all in quotes no matter what type they are. I've removed the type checking code for this reason.
Notes
Jira: https://codefresh-io.atlassian.net/browse/CR-25435