Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add keyless Cosign Image Signing, backport changes from argoproj/argo-workflows #299

Open
wants to merge 17 commits into
base: release-3.4
Choose a base branch
from

Conversation

korenyoni
Copy link

@korenyoni korenyoni commented Jul 31, 2023

  • Add keyless Cosign Signing for OCI container images
  • Add keyless Cosign for misc assets, including sbom and checksums
  • Refactor release workflow secret references (DOCKERIO_ORG previously contained quay.io org... this PR undoes that and instead uses vars.QUAYIO_ORG)
  • Backport windows Dockerfile from argoproj/argo-workflows
  • Backport checksums Makefile target from argoproj/argo-workflows
CleanShot 2023-08-01 at 01 09 23@2x

https://github.com/codefresh-sandbox/argo-workflows/actions/runs/5713351409

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@korenyoni korenyoni marked this pull request as ready for review July 31, 2023 22:18
@korenyoni korenyoni changed the title feat: Add Cosign Image Signing feat: Add Cosign Image Signing, backport changes from argoproj/argo-workflows Jul 31, 2023
@korenyoni korenyoni changed the title feat: Add Cosign Image Signing, backport changes from argoproj/argo-workflows feat: Add keyless Cosign Image Signing, backport changes from argoproj/argo-workflows Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant