Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update repository mutation #573

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented May 19, 2024

Purpose/Motivation

API changes for migrating our internal endpoints from REST to GQL to update a repository. The current internal endpoint updates default branch and repo activated status, and this mutation mimics the same. Follow up PRs will remove the REST code and add the corresponding hook updates in gazebo.

This closes codecov/engineering-team#1748

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (a3a3716) to head (7c25ff0).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #573        +/-   ##
================================================
+ Coverage   95.88000   95.89000   +0.01000     
================================================
  Files           784        787         +3     
  Lines         17503      17555        +52     
================================================
+ Hits          16783      16835        +52     
  Misses          720        720                
Flag Coverage Δ
unit 91.49% <100.00%> (+0.02%) ⬆️
unit-latest-uploader 91.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (a3a3716) to head (7c25ff0).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   91.46%   91.49%   +0.02%     
==========================================
  Files         606      609       +3     
  Lines       16185    16237      +52     
==========================================
+ Hits        14804    14856      +52     
  Misses       1381     1381              
Flag Coverage Δ
unit 91.49% <100.00%> (+0.02%) ⬆️
unit-latest-uploader 91.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mmands/repository/interactors/update_repository.py 100.00% <100.00%> (ø)
core/commands/repository/repository.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...l_api/types/mutation/update_repository/__init__.py 100.00% <100.00%> (ø)
...es/mutation/update_repository/update_repository.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (a3a3716) to head (7c25ff0).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   91.46%   91.49%   +0.02%     
==========================================
  Files         606      609       +3     
  Lines       16185    16237      +52     
==========================================
+ Hits        14804    14856      +52     
  Misses       1381     1381              
Flag Coverage Δ
unit 91.49% <100.00%> (+0.02%) ⬆️
unit-latest-uploader 91.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mmands/repository/interactors/update_repository.py 100.00% <100.00%> (ø)
core/commands/repository/repository.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...l_api/types/mutation/update_repository/__init__.py 100.00% <100.00%> (ø)
...es/mutation/update_repository/update_repository.py 100.00% <100.00%> (ø)

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Add update repository mutation Add update repository mutation May 23, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review May 24, 2024 15:17
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner May 24, 2024 15:17
Copy link
Contributor

@JerrySentry JerrySentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 56dbd5d Jun 4, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/add-update-repo-mutation branch June 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Create a useUpdateRepo GQL mutation
2 participants