Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python.coffee empty if and loop message #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update python.coffee empty if and loop message #166

wants to merge 2 commits into from

Conversation

PhorelliDev
Copy link

No description provided.

@nwinter
Copy link
Contributor

nwinter commented Oct 26, 2016

This is a useful hint, but it might be too long to include. Do you think we can find a way to say it much more shortly?

@PhorelliDev
Copy link
Author

How does Codecombat compile Javascript? Where is the compiler link?

@basicer
Copy link
Member

basicer commented Oct 26, 2016

@PhorelliDev
Copy link
Author

Thanks!

@PhorelliDev
Copy link
Author

What language compiler is easiest for beginner contributors to start off with? May I please get a link to it?

@@ -89,7 +89,7 @@ module.exports = class Python extends Language
type: 'transpile'
reporter: 'aether'
level: 'warning'
message: "Empty loop. Put 4 spaces in front of statements inside loops. Hint: you can do that by pressing the \"Tab\" button on your keyboard a the start of a new line."
message: "Empty loop. Put 4 spaces in front of statements inside loops. Hint: Press \"Tab\" a the start of a new line."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here and line 114? 'Press "Tab" a the start of a new line.' -> 'Press "Tab" at the start of a new line.'

@PhorelliDev
Copy link
Author

What is the easiest place start when contributing to one of your compilers?
Which compiler should I start with?

On Wed, Oct 26, 2016 at 1:50 PM, Imperadeiro98 [email protected]
wrote:

@Imperadeiro98 commented on this pull request.

In src/languages/python.coffee
#166 (review):

@@ -89,7 +89,7 @@ module.exports = class Python extends Language
type: 'transpile'
reporter: 'aether'
level: 'warning'

  •      message: "Empty loop. Put 4 spaces in front of statements inside loops. Hint: you can do that by pressing the \"Tab\" button on your keyboard a the start of a new line."
    
  •      message: "Empty loop. Put 4 spaces in front of statements inside loops. Hint: Press \"Tab\" a the start of a new line."
    

Typo here and line 114? 'Press "Tab" a the start of a new line.' ->
'Press "Tab" at the start of a new line.'


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#166 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARMyJ59fBpf0mG0sOD4aUx-b_WMYiZP2ks5q367ygaJpZM4Kf-rK
.

@PhorelliDev
Copy link
Author

Am I able to join the codecombat archmage team? I know some programming-
Functions, scope, basic syntax, classes(a little bit) and retrieving data through functions.

I am willing and wanting to learn about coding with codecombat, and I can use Javascript.

@nwinter
Copy link
Contributor

nwinter commented Nov 1, 2016

Hey @Thekiddiejsandpython, Filbert is probably the parser to work on: https://github.com/differentmatt/filbert/issues – do you want to help implement some issues there?

Happy to merge this in if you can make sure to sign the CLA and fix the typo noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants