Replace deprecated script and install Node directly from nodesource #1927
Conversation
CodeHex
changed the title
|
When I tested this, I had to use the changes in PR #1900, as I'm working on an M1 Mac. It got through the install steps fine, but someone might want to double check it on a different machine |
I'm glad you used them. Good to get some independent confirmation that they work. |
👍 Yeah thanks, I did get a couple of test failures but running the website seems fine |
| RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - | ||
| # Instructions for installing node from nodesource can be found here: | ||
| # https://github.com/nodesource/distributions | ||
| RUN set -ex; \ |
|
Looks like the install scripts have been undeprecated? https://github.com/nodesource/distributions now suggest we use the script we have in the current Dockerfile. The docs at https://github.com/nodesource/distributions/blob/master/README.md#faq and https://github.com/nodesource/distributions/wiki/Repository-Manual-Installation#-simplified-installation-using-scripts suggest that the script at https://deb.nodesource.com/setup_20.x is supported and recommended. Reading the source of https://deb.nodesource.com/setup_20.x it no longer contains any sleep behaviour. |
Installing Node from nodesource scripts has been very recently deprecated (and sleeps the build for 60s). This replaces the script with installing the signed debian repo directly using the instructions provided here.
Fixes #1926