-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Ember.Logger.info with console.log #63
Conversation
@aliciaphes 👋 Would you mind merging master into your branch. Hopefully the build will pass and we can get this merged! Ref #65 |
@aliciaphes What does If there is an upstream repo, something like this should work!
If not, you can run Lmk if you have any questions! 🙇 |
Hi @snewcomer, I am not sure what I'm doing wrong but I don't seem able to trigger a successful merge. I followed your steps above and my origin is my forked repo from yours; and my upstream is your repo. |
@aliciaphes That's good information! So if you are just using the command line, hopefully the comments below help a tad 🙏.
Also, super sorry if you are using a git client as I'm not too familiar with that workflow 😞. FYI - this article helped me quite a bit - https://hackernoon.com/git-merge-vs-rebase-whats-the-diff-76413c117333 Feel free to reach out again and I will definitely try to help debug this with you! |
Thanks for this. Triggering a new attempt... |
superseded by #67 |
#61
My Hacktoberfest contribution.