Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Close and Reopen conversation parts when conversation is closed or reopened #1378

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

zacck-zz
Copy link
Member

What's in this PR?

This PR adds conversation parts when a conversation is updated with a status of "closed" or "reopened"

References

Fixes #1320 , #1319

Progress on: #1318

… with `part_type: "reopened"`

Add test to for conversation part when updated with a status of reopened

Add tests to check for a conversation_part when a conversation is updated with a status of closed

correct erronous field

add function clauses to handle adding closed and reopned conversation_parts

add reopened flag to possible statuses

add time information to body of closed and reopened event
@zacck-zz zacck-zz force-pushed the close-reopen-conversation-types branch from a902390 to bb8f624 Compare February 15, 2018 19:07
@zacck-zz zacck-zz changed the title Close reopen conversation types Add Close and Reopen conversation parts when conversation is closed or reopened Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create conversation part for closed event when a conversation is closed
2 participants