Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.6] Optimize code size for webgl-device.ts #18207

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[v3.8.6] Optimize code size for webgl-device.ts #18207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dba4a6
[v3.8.6] Optimize code size for webgl-device.ts
dumganhar Jan 17, 2025
45adb0a
Update
dumganhar Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
211 changes: 121 additions & 90 deletions cocos/gfx/webgl/webgl-device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,24 @@ import type { WebGLStateCache } from './webgl-state-cache';
import { WebGLConstants } from '../gl-constants';
import { debug, errorID } from '../../core/platform/debug';

function setFormatFeature (formatFeatures: FormatFeature[], indexArray: Format[], feature: FormatFeature): void {
for (let i = 0; i < indexArray.length; ++i) {
formatFeatures[indexArray[i]] = feature;
}
}

function setFormatFeatureBitwiseOr (formatFeatures: FormatFeature[], indexArray: Format[], feature: FormatFeature): void {
for (let i = 0; i < indexArray.length; ++i) {
formatFeatures[indexArray[i]] |= feature;
}
}

function setTextureExclusive (textureExclusive: boolean[], indexArray: Format[], isExclusive: boolean): void {
for (let i = 0; i < indexArray.length; ++i) {
textureExclusive[indexArray[i]] = isExclusive;
}
}

/** @mangle */
export class WebGLDevice extends Device {
constructor () {
Expand Down Expand Up @@ -110,7 +128,6 @@ export class WebGLDevice extends Device {
private _context: WebGLRenderingContext | null = null;
private _bindingMappings: IWebGLBindingMapping | null = null;

/** @mangle */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebGLDevice is mangled, so all properties in it will be mangled, so it isn't need here.

protected _textureExclusive = new Array<boolean>(Format.COUNT);

public initialize (info: Readonly<DeviceInfo>): boolean {
Expand Down Expand Up @@ -269,57 +286,63 @@ export class WebGLDevice extends Device {
queue.clear();
}

/** @mangle */
minggo marked this conversation as resolved.
Show resolved Hide resolved
protected initFormatFeatures (exts: IWebGLExtensions): void {
const formatFeatures = this._formatFeatures;
const textureExclusive = this._textureExclusive;
formatFeatures.fill(FormatFeatureBit.NONE);

const textureExclusive = this._textureExclusive;
textureExclusive.fill(true);

const tempFeature: FormatFeature = FormatFeatureBit.RENDER_TARGET | FormatFeatureBit.SAMPLED_TEXTURE
| FormatFeatureBit.LINEAR_FILTER;

formatFeatures[Format.RGB8] = tempFeature;
formatFeatures[Format.R5G6B5] = tempFeature;
textureExclusive[Format.R5G6B5] = false;

formatFeatures[Format.RGBA8] = tempFeature;
formatFeatures[Format.RGBA4] = tempFeature;
textureExclusive[Format.RGBA4] = false;

formatFeatures[Format.RGB5A1] = tempFeature;
textureExclusive[Format.RGB5A1] = false;

formatFeatures[Format.DEPTH] = FormatFeatureBit.RENDER_TARGET;
textureExclusive[Format.DEPTH] = false;
formatFeatures[Format.DEPTH_STENCIL] = FormatFeatureBit.RENDER_TARGET;
textureExclusive[Format.DEPTH_STENCIL] = false;

formatFeatures[Format.R8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RG8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGB8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGBA8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;

formatFeatures[Format.R8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RG8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGB8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGBA8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;

formatFeatures[Format.R8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RG8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGB8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGBA8I] |= FormatFeatureBit.VERTEX_ATTRIBUTE;

formatFeatures[Format.R8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RG8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGB8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGBA8UI] |= FormatFeatureBit.VERTEX_ATTRIBUTE;

formatFeatures[Format.R32F] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RG32F] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGB32F] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
formatFeatures[Format.RGBA32F] |= FormatFeatureBit.VERTEX_ATTRIBUTE;
setFormatFeature(formatFeatures, [
Format.RGB8,
Format.R5G6B5,
Format.RGBA8,
Format.RGBA4,
Format.RGB5A1,
], tempFeature);

setFormatFeature(formatFeatures, [
Format.DEPTH,
Format.DEPTH_STENCIL,
], FormatFeatureBit.RENDER_TARGET);

setTextureExclusive(textureExclusive, [
Format.R5G6B5,
Format.RGBA4,
Format.RGB5A1,
Format.DEPTH,
Format.DEPTH_STENCIL,
], false);

setFormatFeatureBitwiseOr(formatFeatures, [
Format.R8I,
Format.RG8I,
Format.RGB8I,
Format.RGBA8I,

Format.R8UI,
Format.RG8UI,
Format.RGB8UI,
Format.RGBA8UI,

Format.R8I,
Format.RG8I,
Format.RGB8I,
Format.RGBA8I,

Format.R8UI,
Format.RG8UI,
Format.RGB8UI,
Format.RGBA8UI,

Format.R32F,
Format.RG32F,
Format.RGB32F,
Format.RGBA32F,
], FormatFeatureBit.VERTEX_ATTRIBUTE);

if (exts.EXT_sRGB) {
formatFeatures[Format.SRGB8] = tempFeature;
Expand Down Expand Up @@ -374,62 +397,70 @@ export class WebGLDevice extends Device {
}

if (exts.WEBGL_compressed_texture_etc) {
formatFeatures[Format.ETC2_RGB8] = compressedFeature;
formatFeatures[Format.ETC2_RGBA8] = compressedFeature;
formatFeatures[Format.ETC2_SRGB8] = compressedFeature;
formatFeatures[Format.ETC2_SRGB8_A8] = compressedFeature;
formatFeatures[Format.ETC2_RGB8_A1] = compressedFeature;
formatFeatures[Format.ETC2_SRGB8_A1] = compressedFeature;
setFormatFeature(formatFeatures, [
Format.ETC2_RGB8,
Format.ETC2_RGBA8,
Format.ETC2_SRGB8,
Format.ETC2_SRGB8_A8,
Format.ETC2_RGB8_A1,
Format.ETC2_SRGB8_A1,
], compressedFeature);
}

if (exts.WEBGL_compressed_texture_s3tc) {
formatFeatures[Format.BC1] = compressedFeature;
formatFeatures[Format.BC1_ALPHA] = compressedFeature;
formatFeatures[Format.BC1_SRGB] = compressedFeature;
formatFeatures[Format.BC1_SRGB_ALPHA] = compressedFeature;
formatFeatures[Format.BC2] = compressedFeature;
formatFeatures[Format.BC2_SRGB] = compressedFeature;
formatFeatures[Format.BC3] = compressedFeature;
formatFeatures[Format.BC3_SRGB] = compressedFeature;
setFormatFeature(formatFeatures, [
Format.BC1,
Format.BC1_ALPHA,
Format.BC1_SRGB,
Format.BC1_SRGB_ALPHA,
Format.BC2,
Format.BC2_SRGB,
Format.BC3,
Format.BC3_SRGB,
], compressedFeature);
}

if (exts.WEBGL_compressed_texture_pvrtc) {
formatFeatures[Format.PVRTC_RGB2] |= compressedFeature;
formatFeatures[Format.PVRTC_RGBA2] |= compressedFeature;
formatFeatures[Format.PVRTC_RGB4] |= compressedFeature;
formatFeatures[Format.PVRTC_RGBA4] |= compressedFeature;
setFormatFeatureBitwiseOr(formatFeatures, [
Format.PVRTC_RGB2,
Format.PVRTC_RGBA2,
Format.PVRTC_RGB4,
Format.PVRTC_RGBA4,
], compressedFeature);
}

if (exts.WEBGL_compressed_texture_astc) {
formatFeatures[Format.ASTC_RGBA_4X4] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_5X4] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_5X5] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_6X5] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_6X6] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_8X5] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_8X6] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_8X8] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_10X5] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_10X6] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_10X8] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_10X10] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_12X10] |= compressedFeature;
formatFeatures[Format.ASTC_RGBA_12X12] |= compressedFeature;

formatFeatures[Format.ASTC_SRGBA_4X4] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_5X4] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_5X5] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_6X5] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_6X6] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_8X5] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_8X6] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_8X8] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_10X5] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_10X6] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_10X8] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_10X10] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_12X10] |= compressedFeature;
formatFeatures[Format.ASTC_SRGBA_12X12] |= compressedFeature;
setFormatFeatureBitwiseOr(formatFeatures, [
Format.ASTC_RGBA_4X4,
Format.ASTC_RGBA_5X4,
Format.ASTC_RGBA_5X5,
Format.ASTC_RGBA_6X5,
Format.ASTC_RGBA_6X6,
Format.ASTC_RGBA_8X5,
Format.ASTC_RGBA_8X6,
Format.ASTC_RGBA_8X8,
Format.ASTC_RGBA_10X5,
Format.ASTC_RGBA_10X6,
Format.ASTC_RGBA_10X8,
Format.ASTC_RGBA_10X10,
Format.ASTC_RGBA_12X10,
Format.ASTC_RGBA_12X12,

Format.ASTC_SRGBA_4X4,
Format.ASTC_SRGBA_5X4,
Format.ASTC_SRGBA_5X5,
Format.ASTC_SRGBA_6X5,
Format.ASTC_SRGBA_6X6,
Format.ASTC_SRGBA_8X5,
Format.ASTC_SRGBA_8X6,
Format.ASTC_SRGBA_8X8,
Format.ASTC_SRGBA_10X5,
Format.ASTC_SRGBA_10X6,
Format.ASTC_SRGBA_10X8,
Format.ASTC_SRGBA_10X10,
Format.ASTC_SRGBA_12X10,
Format.ASTC_SRGBA_12X12,
], compressedFeature);
}
}

Expand Down
Loading