[v3.8.6] Use array.forEach instead of for of to optimize code size (#…

…18112)

cocos/2d/assembler/label/text-processing.ts

@@ -389,14 +389,7 @@ export class TextProcessing {
     }
 
     private _calculateParagraphLength (paragraphedStrings: string[], ctx: CanvasRenderingContext2D, fontDesc: string): number[] {
-        const paragraphLength: number[] = [];
-
-        for (const para of paragraphedStrings) {
-            const width: number = safeMeasureText(ctx, para, fontDesc);
-            paragraphLength.push(width);
-        }
-
-        return paragraphLength;
+        return paragraphedStrings.map((para) => safeMeasureText(ctx, para, fontDesc));
     }
 
     private _updatePaddingRect (style: TextStyle, outputLayoutData: TextOutputLayoutData): void {

cocos/2d/assembler/sprite/bar-filled.ts

@@ -207,11 +207,7 @@ export const barFilled: IAssembler = {
         renderData.chunk.setIndexBuffer(QUAD_INDICES);
 
         // not need
-        const dataList = renderData.data;
-        for (const data of dataList) {
-            data.z = 0;
-        }
-
+        renderData.data.forEach((data) => { data.z = 0; });
         return renderData;
     },
 

cocos/2d/assembler/sprite/radial-filled.ts

@@ -45,7 +45,15 @@ const _center = new Vec2();
 const _triangles: Vec2[] = [new Vec2(), new Vec2(), new Vec2(), new Vec2()];
 let QUAD_INDICES: Uint16Array | null = null;
 
-function _calcIntersectedPoints (left, right, bottom, top, center: Vec2, angle: number, intersectPoints: Vec2[]): void {
+function _calcIntersectedPoints (
+    left: number,
+    right: number,
+    bottom: number,
+    top: number,
+    center: Vec2,
+    angle: number,
+    intersectPoints: Vec2[],
+): void {
     // left bottom, right, top
     let sinAngle = Math.sin(angle);
     sinAngle = Math.abs(sinAngle) > EPSILON ? sinAngle : 0;
@@ -112,9 +120,9 @@ function _calculateVertices (sprite: Sprite): void {
     _vertPos[0].y = _vertPos[1].y = b;
     _vertPos[2].y = _vertPos[3].y = t;
 
-    for (const num of _triangles) {
+    _triangles.forEach((num) => {
         Vec2.set(num, 0, 0);
-    }
+    });
 
     if (cx !== vertices[0]) {
         Vec2.set(_triangles[0], 3, 0);

cocos/2d/assets/bitmap-font.ts

@@ -64,7 +64,7 @@ export class FontAtlas {
 
     public cloneLetterDefinition (): ILetterDefinition {
         const copyLetterDefinitions: ILetterDefinition = {};
-        for (const key of Object.keys(this.letterDefinitions)) {
+        for (const key in this.letterDefinitions) {
             const value = new FontLetterDefinition();
             js.mixin(value, this.letterDefinitions[key]);
             copyLetterDefinitions[key] = value;

cocos/2d/assets/sprite-atlas.ts

@@ -101,7 +101,7 @@ export class SpriteAtlas extends Asset {
         const frames: Array<SpriteFrame | null> = [];
         const spriteFrames = this.spriteFrames;
 
-        for (const key of Object.keys(spriteFrames)) {
+        for (const key in spriteFrames) {
             frames.push(spriteFrames[key]);
         }
 
@@ -114,7 +114,7 @@ export class SpriteAtlas extends Asset {
     public _serialize (ctxForExporting: any): any {
         if (EDITOR || TEST) {
             const frames: string[] = [];
-            for (const key of Object.keys(this.spriteFrames)) {
+            for (const key in this.spriteFrames) {
                 const spriteFrame = this.spriteFrames[key];
                 let id = spriteFrame ? spriteFrame._uuid : '';
                 if (id && ctxForExporting && ctxForExporting._compressUuid) {

cocos/2d/components/rich-text.ts

@@ -547,14 +547,14 @@ export class RichText extends Component {
     }
 
     public onDestroy (): void {
-        for (const seg of this._segments) {
+        this._segments.forEach((seg) => {
             seg.node.removeFromParent();
             if (seg.type === RichTextChildName) {
                 labelPool.put(seg);
             } else if (seg.type === RichTextChildImageName) {
                 imagePool.put(seg);
             }
-        }
+        });
 
         this.node.off(NodeEventType.ANCHOR_CHANGED, this._updateRichTextPosition, this);
         this.node.off(NodeEventType.LAYER_CHANGED, this._applyLayer, this);
@@ -766,7 +766,7 @@ export class RichText extends Component {
     protected _onTouchEnded (event: EventTouch): void {
         const components = this.node.getComponents(Component);
 
-        for (const seg of this._segments) {
+        this._segments.forEach((seg) => {
             const clickHandler = seg.clickHandler;
             const clickParam = seg.clickParam;
             if (clickHandler && this._containsTouchLocation(seg, event.touch!.getUILocation())) {
@@ -778,7 +778,7 @@ export class RichText extends Component {
                 });
                 event.propagationStopped = true;
             }
-        }
+        });
     }
 
     protected _containsTouchLocation (label: ISegment, point: Vec2): boolean {
@@ -1330,9 +1330,9 @@ this._measureText(styleIndex) as unknown as (s: string) => number,
     }
 
     protected _applyLayer (): void {
-        for (const seg of this._segments) {
+        this._segments.forEach((seg) => {
             seg.node.layer = this.node.layer;
-        }
+        });
     }
 
     protected _resetLabelState (label: Label): void {

cocos/3d/assets/mesh.ts

@@ -458,8 +458,9 @@ export class Mesh extends Asset {
                 const attributes: Attribute[] = [];
                 for (let k = 0; k < primitive.vertexBundelIndices.length; k++) {
                     const idx = primitive.vertexBundelIndices[k];
-                    const vertexBundle = this._struct.vertexBundles[idx];
-                    for (const attr of vertexBundle.attributes) {
+                    const attributes = this._struct.vertexBundles[idx].attributes;
+                    for (let j = 0; j < attributes.length; j++) {
+                        const attr = attributes[j];
                         const attribute = new Attribute();
                         attribute.copy(attr);
                         attributes.push(attribute);
@@ -657,13 +658,13 @@ export class Mesh extends Asset {
 
             const subMin = new Vec3();
             const subMax = new Vec3();
-            for (const bound of dynamic.bounds) {
+            dynamic.bounds.forEach((bound) => {
                 if (bound) {
                     bound.getBoundary(subMin, subMax);
                     Vec3.min(minPos, subMin, minPos);
                     Vec3.max(maxPos, subMax, maxPos);
                 }
-            }
+            });
 
             this._struct.minPosition = new Vec3(minPos.x, minPos.y, minPos.z);
             this._struct.maxPosition = new Vec3(maxPos.x, maxPos.y, maxPos.z);
@@ -1310,8 +1311,9 @@ export class Mesh extends Asset {
         if (primitiveIndex >= this._struct.primitives.length) {
             return;
         }
-        const primitive = this._struct.primitives[primitiveIndex];
-        for (const vertexBundleIndex of primitive.vertexBundelIndices) {
+        const vertexBundelIndices = this._struct.primitives[primitiveIndex].vertexBundelIndices;
+        for (let i = 0; i < vertexBundelIndices.length; i++) {
+            const vertexBundleIndex = vertexBundelIndices[i];
             const vertexBundle = this._struct.vertexBundles[vertexBundleIndex];
             const iAttribute = vertexBundle.attributes.findIndex((a) => a.name === (attributeName as string));
             if (iAttribute < 0) {

cocos/3d/assets/morph-rendering.ts

@@ -176,9 +176,9 @@ export class StdMorphRendering implements MorphRendering {
             },
 
             destroy: (): void => {
-                for (const subMeshInstance of subMeshInstances) {
-                    subMeshInstance?.destroy();
-                }
+                subMeshInstances.forEach((subMeshInstance) => {
+                    if (subMeshInstance) subMeshInstance.destroy();
+                });
             },
         };
     }
@@ -289,9 +289,9 @@ class GpuComputing implements SubMeshMorphRendering {
     }
 
     public destroy (): void {
-        for (const attribute of this._attributes) {
+        this._attributes.forEach((attribute) => {
             attribute.morphTexture.destroy();
-        }
+        });
     }
 
     public createInstance (): {
@@ -313,7 +313,8 @@ class GpuComputing implements SubMeshMorphRendering {
             requiredPatches: (): IMacroPatch[] => [{ name: 'CC_MORPH_TARGET_USE_TEXTURE', value: true }],
 
             adaptPipelineState: (descriptorSet: DescriptorSet): void => {
-                for (const attribute of this._attributes) {
+                for (let i = 0; i < this._attributes.length; ++i) {
+                    const attribute = this._attributes[i];
                     let binding: number | undefined;
                     switch (attribute.name) {
                     case AttributeName.ATTR_POSITION: binding = UNIFORM_POSITION_MORPH_TEXTURE_BINDING; break;
@@ -451,7 +452,8 @@ class CpuComputingRenderingInstance implements SubMeshMorphRenderingInstance {
     }
 
     public adaptPipelineState (descriptorSet: DescriptorSet): void {
-        for (const attribute of this._attributes) {
+        for (let i = 0; i < this._attributes.length; ++i) {
+            const attribute = this._attributes[i];
             const attributeName = attribute.attributeName;
             let binding: number | undefined;
             switch (attributeName) {

cocos/3d/misc/buffer.ts

@@ -58,8 +58,12 @@ export function writeBuffer (target: DataView, data: number[], format: Format =
     }
 }
 export function readBuffer (
-    target: DataView, format: Format = Format.R32F, offset = 0,
-    length: number = target.byteLength - offset, stride = 0, out: number[] = [],
+    target: DataView,
+    format: Format = Format.R32F,
+    offset = 0,
+    length: number = target.byteLength - offset,
+    stride = 0,
+    out: number[] = [],
 ): number[] {
     const info = FormatInfos[format];
     if (!stride) { stride = info.size; }
@@ -78,8 +82,13 @@ export function readBuffer (
     return out;
 }
 export function mapBuffer (
-    target: DataView, callback: (cur: number, idx: number, view: DataView) => number, format: Format = Format.R32F,
-    offset = 0, length: number = target.byteLength - offset, stride = 0, out?: DataView,
+    target: DataView,
+    callback: (cur: number, idx: number, view: DataView) => number,
+    format: Format = Format.R32F,
+    offset = 0,
+    length: number = target.byteLength - offset,
+    stride = 0,
+    out?: DataView,
 ): DataView {
     if (!out) { out = new DataView(target.buffer.slice(target.byteOffset, target.byteOffset + target.byteLength)); }
     const info = FormatInfos[format];

cocos/3d/misc/create-mesh.ts

@@ -55,12 +55,7 @@ export function createMesh (geometry: IGeometry, out?: Mesh, options?: ICreateMe
     if (positions.length > 0) {
         attr = null;
         if (geometry.attributes) {
-            for (const att of geometry.attributes) {
-                if (att.name === (AttributeName.ATTR_POSITION as string)) {
-                    attr = att;
-                    break;
-                }
-            }
+            attr = geometry.attributes.find((att) => att.name === AttributeName.ATTR_POSITION) || null;
         }
 
         if (!attr) {
@@ -77,12 +72,7 @@ export function createMesh (geometry: IGeometry, out?: Mesh, options?: ICreateMe
     if (geometry.normals && geometry.normals.length > 0) {
         attr = null;
         if (geometry.attributes) {
-            for (const att of geometry.attributes) {
-                if (att.name === (AttributeName.ATTR_NORMAL as string)) {
-                    attr = att;
-                    break;
-                }
-            }
+            attr = geometry.attributes.find((att) => att.name === AttributeName.ATTR_NORMAL) || null;
         }
 
         if (!attr) {
@@ -99,12 +89,7 @@ export function createMesh (geometry: IGeometry, out?: Mesh, options?: ICreateMe
     if (geometry.uvs && geometry.uvs.length > 0) {
         attr = null;
         if (geometry.attributes) {
-            for (const att of geometry.attributes) {
-                if (att.name === (AttributeName.ATTR_TEX_COORD as string)) {
-                    attr = att;
-                    break;
-                }
-            }
+            attr = geometry.attributes.find((att) => att.name === AttributeName.ATTR_TEX_COORD) || null;
         }
 
         if (!attr) {
@@ -121,12 +106,7 @@ export function createMesh (geometry: IGeometry, out?: Mesh, options?: ICreateMe
     if (geometry.tangents && geometry.tangents.length > 0) {
         attr = null;
         if (geometry.attributes) {
-            for (const att of geometry.attributes) {
-                if (att.name === (AttributeName.ATTR_TANGENT as string)) {
-                    attr = att;
-                    break;
-                }
-            }
+            attr = geometry.attributes.find((att) => att.name === AttributeName.ATTR_TANGENT) || null;
         }
 
         if (!attr) {
@@ -143,12 +123,7 @@ export function createMesh (geometry: IGeometry, out?: Mesh, options?: ICreateMe
     if (geometry.colors && geometry.colors.length > 0) {
         attr = null;
         if (geometry.attributes) {
-            for (const att of geometry.attributes) {
-                if (att.name === (AttributeName.ATTR_COLOR as string)) {
-                    attr = att;
-                    break;
-                }
-            }
+            attr = geometry.attributes.find((att) => att.name === AttributeName.ATTR_COLOR) || null;
         }
 
         if (!attr) {
@@ -179,9 +154,9 @@ export function createMesh (geometry: IGeometry, out?: Mesh, options?: ICreateMe
     // Fill vertex buffer.
     const vertexBuffer = new ArrayBuffer(vertCount * stride);
     const vertexBufferView = new DataView(vertexBuffer);
-    for (const channel of channels) {
+    channels.forEach((channel) => {
         writeBuffer(vertexBufferView, channel.data, channel.attribute.format, channel.offset, stride);
-    }
+    });
     bufferBlob.setNextAlignment(0);
     const vertexBundle: Mesh.IVertexBundle = {
         attributes,

cocos/3d/misc/read-mesh.ts

@@ -39,17 +39,17 @@ export function readMesh (mesh: Mesh, iPrimitive = 0): IGeometry {
     const dataView = new DataView(mesh.data.buffer, mesh.data.byteOffset, mesh.data.byteLength);
     const struct = mesh.struct;
     const primitive = struct.primitives[iPrimitive];
-    for (const idx of primitive.vertexBundelIndices) {
+    primitive.vertexBundelIndices.forEach((idx) => {
         const bundle = struct.vertexBundles[idx];
         let offset = bundle.view.offset;
         const { length, stride } = bundle.view;
-        for (const attr of bundle.attributes) {
+        bundle.attributes.forEach((attr) => {
             const name: AttributeName = _keyMap[attr.name];
             if (name) { out[name] = (out[name] || []).concat(readBuffer(dataView, attr.format, offset, length, stride)); }
             offset += FormatInfos[attr.format].size;
-        }
-    }
+        });
+    });
     const view = primitive.indexView!;
-    out.indices = readBuffer(dataView, Format[`R${view.stride * 8}UI`], view.offset, view.length);
+    out.indices = readBuffer(dataView, Format[`R${view.stride * 8}UI`] as Format, view.offset, view.length);
     return out;
 }

cocos/3d/skeletal-animation/skeletal-animation.ts

@@ -237,7 +237,7 @@ export class SkeletalAnimation extends Animation {
      * @zh 重建动画并立即同步所有挂点的转换矩阵到它们的目标节点上。
      */
     public rebuildSocketAnimations (): void {
-        for (const socket of this._sockets) {
+        this._sockets.forEach((socket) => {
             const joint = this.node.getChildByPath(socket.path);
             const { target } = socket;
             if (joint && target) {
@@ -247,8 +247,8 @@ export class SkeletalAnimation extends Animation {
                 Mat4.fromRTS(m4_2, target.rotation, target.position, target.scale);
                 if (!Mat4.equals(m4_2, m4_1)) { target.matrix = m4_1; }
             }
-        }
-        for (const stateName of Object.keys(this._nameToState)) {
+        });
+        for (const stateName in this._nameToState) {
             const state = this._nameToState[stateName] as SkeletalAnimationState;
             state.rebuildSocketCurves(this._sockets);
         }

cocos/animation/animation-component.ts

@@ -69,17 +69,17 @@ export class Animation extends Eventify(Component) {
             this._crossFade.clear();
         }
         // Remove state for old automatic clips.
-        for (const clip of this._clips) {
+        this._clips.forEach((clip) => {
             if (clip) {
                 this._removeStateOfAutomaticClip(clip);
             }
-        }
+        });
         // Create state for new clips.
-        for (const clip of value) {
+        value.forEach((clip) => {
             if (clip) {
                 this.createState(clip);
             }
-        }
+        });
         // Default clip should be in the list of automatic clips.
         const newDefaultClip = value.find((clip) => equalClips(clip, this._defaultClip));
         if (newDefaultClip) {