roachtest: fix network/authentication/nodes=4 #138816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons, the test starts a three node cluster, then immediately
stops it, then restarts n1 and {n2,n3} separately. It was previously
restarting n1 first, followed by `{n2,n3}`. Due to recent change
PR cockroachdb#138109, this no longer works since n1 doesn't have quorum and
so won't signal SQL readiness.
There's an ongoing discussion on whether this new behavior is desired,
but either way, this PR changes the test to restart {n2,n3} first (which
does have quorum, assuming we wait for full replication first, which we
now do as well), followed by n1.
Closes cockroachdb#138806.
Epic: none
Release note: None
|
This change is |
Sorry for causing a regression; I thought I had smoke tested everything, but this one somehow eluded the smoke tests. We could make an opt-out from waiting for sql for special cases like this one. (There is one already for some acceptance tests which don't use cluster init on startup.) |
srosenberg
approved these changes
Jan 10, 2025
miraradeva
approved these changes
Jan 13, 2025
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons, the test starts a three node cluster, then immediately
stops it, then restarts n1 and {n2,n3} separately. It was previously
restarting n1 first, followed by
{n2,n3}. Due to recent changePR #138109, this no longer works since n1 doesn't have quorum and
so won't signal SQL readiness.
There's an ongoing discussion on whether this new behavior is desired,
but either way, this PR changes the test to restart {n2,n3} first (which
does have quorum, assuming we wait for full replication first, which we
now do as well), followed by n1.
Closes #138806.
Epic: none
Release note: None