Separate SrvFormat into ROS1 and ROS2 versions #451 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored action format * Refactored ActionFormat * Some merging problem? * Updated generics and attr use, and refactored appropriately. * Fix cryptograhy build error in tox (#452) * Install rust * Sudo * Trying curl * Interactive * Interactive * Updating pip * Updating pip * Updating pip * Debugging * Debugging * Debugging * Back to curl * Separate script invocation * Setup path to rust * Setup path to rust * DONT BUILD RUST * DONT BUILD RUST 2 * DONT BUILD RUST 3 * Install cryptography 3.2.1 in reqs.dev.txt * Undo all of rust installation. * Bump cryptography from 3.2.1 to 3.3.2 (#453) Bumps [cryptography](https://github.com/pyca/cryptography) from 3.2.1 to 3.3.2. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@3.2.1...3.3.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactored action format * Refactored ActionFormat * Some merging problem? * Updated generics and attr use, and refactored appropriately. * Beginning of msgformat refactor * Formatting * Not sure how the other branch crept in. * Not sure how the other branch crept in. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
test/test_format.py
Outdated
| @@ -7,10 +7,10 @@ | |||
| from roswire.common import ( | |||
| Constant, | |||
| Field, | |||
| MsgFormat, | |||
| SrvFormat, | |||
| MsgFormat,, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the moment, the ROS1 and ROS2 functionality are the same. Related to #420