WIP Built some initial e2e datafusion infrastructure #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortsui20
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Should we call this optd-datafusion instead or something more descriptive than "infra"?
Make sure to fix all of the clippy lints (you can either look at the Files changed tab on GitHub or just run cargo clippy --all-targets
Also, please add comments on everything because I can't really understand the code...
See the official Rust style guide as well for things that clippy cant check (things like full punctuation on comments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to be able to run our queries on datafusion.
Summary of changes
The only update I have is that I have setup the datafusion e2e to be able to run multiple queries and print the results and the plans. Currently, since we do not have an optimizer built out and we don’t have an logical plan IR to convert the datafusion logical plan into, I am simply running the datafusion optimizer.