Remove unused variable in TestAssociator.cc

[iarspider]

PR description:

Fixes clang warning:

  src/SimTracker/TrackerHitAssociation/test/TestAssociator.cc:112:36: warning: variable 'dummy' set but not used [-Wunused-but-set-variable]
   112 |           if (const SiPixelRecHit* dummy = dynamic_cast<const SiPixelRecHit*>(&rechit)) {
      |                                    ^

PR validation:

Bot tests

[iarspider]

please test for CMSSW_15_0_CLANG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47199/43464

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• SimTracker/TrackerHitAssociation (simulation)

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @missirol, @mmusich, @mtosi, @rovere, @threus, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb99ea/44014/summary.html
COMMIT: 992d2ed
CMSSW: CMSSW_15_0_CLANG_X_2025-01-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47199/44014/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @SegmentLinking LST followups: better work divisions, concrete kernel dimension, some cleanup and fixes #47084
• @missirol update TestGlobalObjectMapRecordFormat unit test with CMSSW_15_0_0_pre2 inputs #47146
• @jhakala HcalNano for MC #47102

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb99ea/44014/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb99ea/44014/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestGlobalObjectMapRecordFormat had ERRORS

Comparison Summary

Summary:

• You potentially removed 292 lines from the logs
• Reco comparison results: 103755 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4016770
• DQMHistoTests: Total failures: 483098
• DQMHistoTests: Total nulls: 290
• DQMHistoTests: Total successes: 3533362
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.7510000000000003 KiB( 49 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): 1.215 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 141.042 ): -0.023 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.014 ): 0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.104 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.202 ): 0.035 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.408 ): -0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.5 ): 0.027 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.604 ): 0.055 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.713 ): 0.012 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 17034.0 ): ...
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: found differences in 21 / 48 workflows