Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4

[eigen1907]

PR description:

This PR modifies the isFront function inside the RPC Endcap Geometry Builder.
It will be applied in synchronization with PR (#47134) by Sunanda Banerjee.

The isFront function classifies RPCs as front or back chambers by RPC Ids.

As the PR (#47134) modifies the z coordinates of RPCs inside RPC endcap stations (RE-4, RE-3, RE-2, RE+2, RE+3, RE+4),
The criteria for the isFront function needs to be changed as well.
Therefore, this PR modifies the criteria for the isFront function correctly as the z coordinate changes.

For history and more details, see the previous meeting materials.
(https://indico.cern.ch/event/1475698/contributions/6214667/attachments/2962024/5210467/RPCGeomReport_241106RPCDPG_JShin.pdf)

PR validation:

To avoid errors, this PR should be used with #47134 and the new scenario.
Otherwise (when applying this PR alone), the error below will be raised by the selfTest function in the Geometry Builder.

Error reproduction)

A fatal system signal has occurred: abort signal
The following is the call stack containing the origin of the signal.
...
#9  0x00007f62d8e9276c in MuRingForwardDoubleLayer::selfTest() const () from /eos/home-j/joshin/workspace-eos/rpc-geometry/update-isfront/CMSSW_15_0_0_pre1/lib/el9_amd64_gcc12/libRecoMuonDetLayers.so
#10 0x00007f62d8e9359b in MuRingForwardDoubleLayer::MuRingForwardDoubleLayer(std::vector<ForwardDetRing const*, std::allocator<ForwardDetRing const*> > const&, std::vector<ForwardDetRing const*, std::allocator<ForwardDetRing const*> > const&) () from /eos/home-j/joshin/workspace-eos/rpc-geometry/update-isfront/CMSSW_15_0_0_pre1/lib/el9_amd64_gcc12/libRecoMuonDetLayers.so
#11 0x00007f62d8e9f36f in MuonRPCDetLayerGeometryBuilder::buildLayer(int, std::vector<int, std::allocator<int> > const&, int, int, std::vector<int, std::allocator<int> >&, RPCGeometry const&) () from /eos/home-j/joshin/workspace-eos/rpc-geometry/update-isfront/CMSSW_15_0_0_pre1/lib/el9_amd64_gcc12/libRecoMuonDetLayers.so
#12 0x00007f62d8e9fea8 in MuonRPCDetLayerGeometryBuilder::buildEndcapLayers(RPCGeometry const&) () from /eos/home-j/joshin/workspace-eos/rpc-geometry/update-isfront/CMSSW_15_0_0_pre1/lib/el9_amd64_gcc12/libRecoMuonDetLayers.so
#13 0x00007f62bb85a0bf in MuonDetLayerGeometryESProducer::produce(MuonRecoGeometryRecord const&) () from /cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_15_0_0_pre1/lib/el9_amd64_gcc12/pluginRecoMuonDetLayersPlugins.so
...

This change will also require a new payload for RPC Geometry when working with Global Tags.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47138/43365

[cmsbuild]

A new Pull Request was created by @eigen1907 for master.

It involves the following packages:

• RecoMuon/DetLayers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @bellan, @cericeci, @jhgoh, @missirol, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test
(#47134 is already merged in the IBs)

[bsunanda]

The new scenarios are in #47158 (Run2), #47159 (Run3) and #47160 (Run4).

[perrotta]

please abort

[perrotta]

test parameters:

• pull_requests = Run3-gex186A Modify all Run2 scenarios to include the modified RPC geometry #47158, Run3-gex186B Modify all Run3 scenarios to include the modified RPC geometry #47159, Phase2-gex186C Modify all Run4 scenarios to include the modified RPC geometry #47160

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09a151/43910/summary.html
COMMIT: 185af90
CMSSW: CMSSW_15_0_X_2025-01-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47138/43910/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS

RelVals

• 135.4A fatal system signal has occurred: abort signal
• 1306.0A fatal system signal has occurred: abort signal
• 7.3A fatal system signal has occurred: abort signal

Expand to see more relval errors ...

• 140.045
• 10224.0
• 4.53
• 5.1
• 312.0
• 145.713
• 145.301
• 13234.0
• 1000.0
• 16834.0
• 11634.0
• 136.874
• 9.0
• 145.202
• 14234.0
• 8.0
• 136.731
• 13034.0
• 136.793
• 141.042
• 12846.0
• 4.22
• 25.0
• 25202.0
• 145.408
• 1330.0
• 250202.181
• 145.014
• 14034.0
• 145.104
• 139.001
• 140.56
• 1001.0
• 12834.7
• 12434.0
• 145.5
• 12834.0
• 145.604

RelVals-INPUT

• 145.711145.711_RunParkingSingleMuon02024I/step2_RunParkingSingleMuon02024I.log
• 1030.01030.0_RunHLTPhy2017B/step2_RunHLTPhy2017B.log
• 145.7145.7_RunBTagMu2024I/step2_RunBTagMu2024I.log

Expand to see more relval errors ...

• 145.31
• 1052.0
• 1052.1
• 145.114
• 145.109
• 142.0
• 145.209
• 145.611
• 145.01
• 145.612
• 145.11
• 145.409
• 145.408
• 145.613
• 145.401
• 145.614
• 145.403
• 145.402
• 145.405
• 145.404
• 145.407
• 145.406
• 144.6
• 1002.0
• 1002.3
• 1002.4
• 138.5
• 138.4
• 138.2
• 138.1
• 142.903
• 142.902
• 142.901
• 145.414
• 145.412
• 145.413
• 136.897
• 136.899
• 1000.0
• 145.714
• 145.009
• 145.008
• 145.713
• 145.712
• 145.005
• 145.004
• 145.007
• 145.006
• 145.001
• 145.609
• 145.003
• 145.002
• 145.61
• 145.1
• 1040.0
• 2500.242
• 134.813
• 145.702
• 145.703
• 145.701
• 145.706
• 145.707
• 145.704
• 145.0
• 145.012
• 145.013
• 145.708
• 145.011
• 145.014
• 140.57
• 145.311
• 145.313
• 145.312
• 145.314
• 145.71
• 134.0
• 145.306
• 145.307
• 145.304
• 145.305
• 145.302
• 145.303
• 145.301
• 145.308
• 145.309
• 140.61
• 136.733
• 145.41
• 145.705
• 141.901
• 141.902
• 145.608
• 143.911
• 145.603
• 145.602
• 145.601
• 145.607
• 145.606
• 145.605
• 145.604
• 145.709
• 145.51
• 145.411
• 145.513
• 145.512
• 145.511
• 145.514
• 4.6
• 145.106
• 143.902
• 1001.4
• 143.901
• 145.113
• 145.112
• 145.111
• 145.208
• 145.207
• 145.206
• 145.205
• 145.204
• 145.203
• 145.202
• 145.201
• 1001.3
• 1001.0
• 1005.0
• 145.501
• 145.502
• 145.503
• 145.504
• 145.505
• 145.506
• 145.507
• 145.508
• 145.509
• 4.22
• 145.21
• 136.902
• 136.903
• 136.901
• 1003.0
• 136.904
• 145.108
• 145.2
• 145.104
• 145.105
• 140.56
• 145.107
• 1001.2
• 145.101
• 145.102
• 145.103
• 145.214
• 145.6
• 145.5
• 145.4
• 145.3
• 145.211
• 145.212
• 145.213

AddOn Tests

• fastsim

A fatal system signal has occurred: abort signal

• fastsim1

A fatal system signal has occurred: abort signal

• fastsim2

A fatal system signal has occurred: abort signal

Expand to see more addon errors ...

• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_Special
• hlt_mc_Special
• hlt_data_Fake
• hlt_data_Fake1
• hlt_data_Fake2
• hlt_data_GRun
• hlt_data_GRun
• hlt_data_HIon
• hlt_data_PIon
• hlt_data_PRef
• hlt_data_PRef
• hlt_data_Special
• hlt_data_Special

[jhgoh]

The errors such as the WF 140.045 are expected

cmsRun: src/RecoMuon/DetLayers/src/MuRingForwardDoubleLayer.cc:196: void MuRingForwardDoubleLayer::selfTest() const: Assertion `frontz < backz' failed.

already written in the PR description.

[jfernan2]

@jhgoh I do not fully understand, according to your description, the error should not be present since #47134 has been already merged? Am I missing anything?

[bsunanda]

There are 3 more PRs that are to be merged #47158, #47159 and #47160. In fact all tests have to be used from XML files and not from DB. The DB payloads need to be recreated once this PR is merged.

…

________________________________ From: jfernan2 ***@***.***> Sent: 23 January 2025 00:27 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Comment ***@***.***> Subject: Re: [cms-sw/cmssw] Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4 (PR #47138) @jhgoh<https://github.com/jhgoh> I do not fully understand, according to your description, the error should not be present since #47134<#47134> has been already merged? Am I missing anything? — Reply to this email directly, view it on GitHub<#47138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORNIPGSDOBLT27O5632L7SZLAVCNFSM6AAAAABVPZ3DUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBYGAZDSNBXGQ>. You are receiving this because you commented.Message ID: ***@***.***>

[jfernan2]

There are 3 more PRs that are to be merged #47158, #47159 and #47160. In fact all tests have to be used from XML files and not from DB. The DB payloads need to be recreated once this PR is merged.

But those are included in the test_parameters of this PR, I understand this is not enough either? Thanks

[eigen1907]

There are 3 more PRs that are to be merged #47158, #47159 and #47160. In fact all tests have to be used from XML files and not from DB. The DB payloads need to be recreated once this PR is merged.

But those are included in the test_parameters of this PR, I understand this is not enough either? Thanks

The three PRs change the scenario for calling xml geometry.

The DB payload hasn't changed yet, so scenarios that call geometry from the DB will throw an error.

Best regards,

[jfernan2]

Ok thanks. So, I understand this PR should be approved and merged to create the DB payloads but we cannot test it in advance. Is there any local test which can prove it works? Thanks

[perrotta]

assign alca

[cmsbuild]

New categories assigned: alca

@atpathak,@consuegs,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

[perrotta]

I don't think this PR cannot be approved now: we cannot modify Run2+Run3 geometries now without a thorough discussion.
Would it be limited to 2025 it would be a different story (but still the changes have to be discussed)

[perrotta]

assign alca

(at least until a modification of the conditions is required to have it working)

[eigen1907]

Ok thanks. So, I understand this PR should be approved and merged to create the DB payloads but we cannot test it in advance. Is there any local test which can prove it works? Thanks

I'm attaching a slide with more background information and a local test (backup slide) manual for this PR.
RPCGeometryChanges_250120_JShin

[eigen1907]

I don't think this PR cannot be approved now: we cannot modify Run2+Run3 geometries now without a thorough discussion. Would it be limited to 2025 it would be a different story (but still the changes have to be discussed)

If so, it seems that these three PRs #47158, #47159 and #47160 should not be applied as well.
They only work without error when applied in conjunction with the current open #47138.

I think this PR (#47138) and the scenario update PRs (#47158, #47159 and #47160) should be on hold until there are payloads update in the database to reflect the new geometry xml files in #46670 (2025 Geometry), #47134 (Run2, Run3, Phase2 Geometries).

please confirm @bsunanda

[bsunanda]

Before making payloads like to know which geometries are to be updated. I would like this to be discussed in PPD and/or SIM meeting