Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 optical functions including strips #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

michael-pitt
Copy link

The first version of optical function using Run3 settings, produced from MAD-X source files available in /afs/cern.ch/eng/lhc/optics/runIII/RunIII_dev/Proton_2022/

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2022

A new Pull Request was created by @michael-pitt (Michael Pitt) for branch master.

@smuzaffar, @yuanchao, @malbouis, @aandvalenzuela, @iarspider, @cmsbuild, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @fabferro, @mmusich, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #6 was updated.

@michael-pitt
Copy link
Author

The updated files can be consumed by the proton reconstruction package once uploaded, anything preventing from uploading these files?

Thanks

@tvami
Copy link

tvami commented Jul 27, 2022

Why arent these going to the GT? I thought we have a record the optical functions in the DB, so what's the point of this PR per se? @wpcarvalho would you please comment?

@michael-pitt
Copy link
Author

michael-pitt commented Jul 27, 2022

Hi @tvami

Proton reconstruction software for using the files from https://github.com/cms-sw/cmssw/blob/master/CalibPPS/ESProducers/python/ctppsOpticalFunctions_non_DB_cff.py, the updated the proton reconstruction software to use the input files from DB is foreseen. Still, for now, we would like to have these files locally also for test purposes.

@wpcarvalho
Copy link

wpcarvalho commented Aug 3, 2022 via email

@cmsbuild
Copy link
Contributor

Pull request #6 was updated.

@michael-pitt
Copy link
Author

I updated the PR with optical functions of the second diamond station

@cmsbuild
Copy link
Contributor

Pull request #6 was updated.

@tvami
Copy link

tvami commented Aug 16, 2022

So I chatted with Wagner about this... these are the input files to create the sqlite files, so they are not directly used in CMSSW. Can you confirm @michael-pitt ? If this is the case, this might not be the best place for it, but it's also OK to keep it here just for the documentation purposes.

@wpcarvalho
Copy link

I think they should go into:

/cvmfs/cms.cern.ch/share/cms/data-CalibPPS-ESProducers/V01-04-00/CalibPPS/ESProducers/data/optical_functions/

But I don't know how to commit them there.

@smuzaffar
Copy link
Contributor

smuzaffar commented Aug 17, 2022

@wpcarvalho , once this PR is signed and merged then next 12.5 pre-release witll deploy it under cvmfs

@tvami
Copy link

tvami commented Aug 17, 2022

But @wpcarvalho why do you need it under cvmfs ?

@michael-pitt
Copy link
Author

Dear all,
currently, proton simulation uses the non DB version of the optical files CalibPPS/ESProducers/ctppsOpticalFunctions_non_DB_cff.py (which is also needs to be updated) therefore we need to upload them to the cms-data. Switching to DB inputs is also considered, but for now, it is not implemented.

@wpcarvalho
Copy link

@wpcarvalho , once this PR is signed and merged then next 12.5 pre-release withh deploy it under cvmfs

Thanks for explain it.

@wpcarvalho
Copy link

But @wpcarvalho why do you need it under cvmfs ?

Hi @tvami , I only know that I can find it there in the path. I think @michael-pitt has explained better why it is needed in cms-data.

@tvami
Copy link

tvami commented Aug 17, 2022

Switching to DB inputs is also considered, but for now, it is not implemented.

When is it expected to be implemented? AlCa strongly supports to read these from the DB instead of cms-data, especially since the payloads are in the DB, so it's just the consume part that's missing

@smuzaffar
Copy link
Contributor

ping
should we keep it open?

@tvami
Copy link

tvami commented Jul 20, 2023

Hi @wpcarvalho , do you have any news on this?

@wpcarvalho
Copy link

Hi @wpcarvalho , do you have any news on this?

Hi @tvami , I have to talk to the simulation experts to see if anybody has made any work on this front.

@smuzaffar
Copy link
Contributor

ping
was there any update for this?

@wpcarvalho
Copy link

Hi @smuzaffar , sorry for this long-standing open issue. We are in the process of reviewing the optical functions conditions for 2024 and for 2022+2023 ReReco and I'll take this opportunity to discuss with the experts in the group the use cases of DB and non-DB, and see if we can switch to DB only usage. I'll put this high in my priority list.

@diemort
Copy link
Contributor

diemort commented Sep 13, 2024

Dear all, posting an feedback here since my new PR (#7) is going in the same direction. We're in the process of validating the PPS simulation, especially the version integrated to CMSSW. The original version of our fast simulation is based on local files and cannot read conditions from DB. Once this validation is done, the full and fast simulation won't rely on local files anymore for 12.5+, so keeping this area will serve as a local source for Run2 conditions only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants