Don't do public accessor workarounds if not needed #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some public accessor hacks are now hidden behind preprocessor macros. This will serve as a reminder to remove these workarounds in the far future when combine doesn't support old ROOT versions anymore.
|
@guitargeek - I don't think we have any specific checks other than compilation in the CI. Did you try running combine on a tutorial datacard to make sure nothing breaks with this? |
|
Hi Nick, thanks for you comment! I think the CI actually does more checks other than compilation: If you expand the logs for the "Run tests" step, you can see what it does. It this enough to validate the changes in this PR, or you want me to do something else? |
|
Ah right, these have been added now - that was the kind of thing I was after - thanks! |
|
Shall we merge this? |
|
Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some public accessor hacks are now hidden behind preprocessor macros. This will serve as a reminder to remove these workarounds in the far future when combine doesn't support old ROOT versions anymore.