Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the relevant files to build combine with CMake. I had this around privately for a long time, and I think it would be good to expose this also to other users and developers that want to build combine with CMake.
It is a draft PR for now because there is still something I want to improve: right now, the python libraries are always installed in the system Python package directory, but it would be good to have a configuration option maybe called
PYTHON_LOCAL
to install to the local library directory for the user (like--local
for pip). I will implement this when I have time, but I still wanted to open the PR already to get feedback from interested people that want to give it a shot.You can try it out with:
Unlike the standalone
Makefile
that is already in the repo, this should work not only on lxplus because of the smart CMake macros that try to find the dependencies at the right place.Tested on:
I'll try to make it work for the "vanilla" versions of the operating systems, so no
cmsenv
allowed for example. A yellow sign means it doesn't work immediately out of the box, but after only small adaptations to the environment like sourcing a newer ROOT version.lxplus7
) ❌lxplus8
) ➕Still todo:
PYTHON_LOCAL
option described beforeremove restriction that source code directory must be namedDONEHiggsAnalysis/CombinedLimit