Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl timeout #8

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Add curl timeout #8

merged 2 commits into from
Jul 12, 2019

Conversation

jmorten
Copy link

@jmorten jmorten commented May 3, 2019

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • [n/a] for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • [n/a] for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • [n/a] if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • [n/a] add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

@jmorten
Copy link
Author

jmorten commented May 6, 2019

The failed checks don't seem like it was an issue with the code.

@antoine-sachet
Copy link
Member

antoine-sachet commented May 31, 2019

I understand why you did this (I am running into the same slowness issue on my local machine, related to cloudyr/aws.signature#33 and #7) but I am concerned that this may break my production code (actually running on ec2 and ecs). What if AWS takes more than 100ms to respond?

Copy link
Contributor

@jon-mago jon-mago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks so much for this. I'm sorry it's taken me forever to review it.

I'm happy with this change in principle, but I'd like to change the timeout to 1000ms to bring it in line with the default timeout from boto3 (controlled by AWS_METADATA_SERVICE_TIMEOUT).

@jon-mago jon-mago merged commit 4df1b9a into cloudyr:master Jul 12, 2019
@jmorten jmorten deleted the add-curl-timeout branch November 27, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants