feat: support zero copy for object or array owned value #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuq19
reviewed
Jan 9, 2025
liuq19
reviewed
Jan 9, 2025
liuq19
previously approved these changes
Jan 10, 2025
liuq19
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: support zero copy for object or array owned value
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
In the previous implementation, the copy overhead of the value data structure would increase as the value contained an owned array or an owned object.
The test conditions are:
environment: Apple M2 pro chip 12C, 3.5 GHertz; 32 G memory
data source: twitter.json, operation: after making one modification, copy 10 times continuously.
The test results are:
We can see that the overhead of sonic is 1.6 microseconds and the overhead of serde is 15 milliseconds.
In order to reduce the copy overhead here, use arc to reconstruct the owned array and object data structures, and only perform deep copies when modifications occur.
The new test results are:
We can see that the clone of sonic value overhead dropped from 1.6 microseconds to 260 nanoseconds.
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: