chore: Update from functions to functions2 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I suggest this go into V3? |
|
@henrybell if you're looking to cut v3 please consider this one |
henrybell
force-pushed
the
feature/cloudfunctions2
branch
2 times, most recently
from
0e1b33d to
6d1a731
Compare
|
/gcbrun |
henrybell
changed the title
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
henrybell
force-pushed
the
feature/cloudfunctions2
branch
from
c23dc72 to
4875218
Compare
|
/gcbrun |
nielm
force-pushed
the
feature/cloudfunctions2
branch
from
4875218 to
d20dfa3
Compare
|
/gcbrun |
nielm
reviewed
Oct 25, 2024
nielm
force-pushed
the
feature/cloudfunctions2
branch
from
d20dfa3 to
87a221c
Compare
|
The most recent commit 87a221c is a squash of the existing commits and an update of the commit message so that the breaking change information appears in the changelog |
|
/gcbrun |
This changes the runtime from Cloud Functions (1st Gen) to Cloud Run Functions (aka Cloud Functions (2nd gen)). BREAKING CHANGE: Use of Cloud Run Functions will require additional APIs to be enabled before redeploying - see the documentation for cloud functions deployment for the command to run. Co-authored-by: Niel Markwick <[email protected]> Co-authored-by: henrybell <[email protected]>
henrybell
force-pushed
the
feature/cloudfunctions2
branch
from
87a221c to
d8dfe3a
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
Thanks @a5chin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The version of cloud functions written in terraform was 1st gen, so I updated it to 2nd gen.
google_cloudfunctions_function->google_cloudfunctions2_functionWhy you need this PR
As shown below, the 2nd generation is recommended over the 1st generation in Google Cloud.
https://cloud.google.com/functions/docs/concepts/version-comparison
What I did
The following 2 files have been updated.
autoscalse/terraform/modules/autoscaler-functions/main.tfautoscalse/terraform/modules/forwarder/main.tfFYI
Already tested with our products.