Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated athena macros policies_have_wildcard_actions #958

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: Updated athena macros policies_have_wildcard_actions #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
131b15d
fix: Updated athena macros policies_have_wildcard_actions and policie…
ronsh12 Jul 1, 2024
df3ef77
Merge branch 'main' into private/ron/aws/athena_macros_wildcard
k-rheinheimer Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions transformations/aws/macros/iam/policies_have_wildcard_actions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,13 @@ policy_statements AS (
id,
account_id,
arn,
t.statement
t.statement,
CASE
WHEN json_array_length(json_extract(t.statement, '$.Action')) IS NULL THEN
json_parse('["' || json_extract_scalar(t.statement, '$.Action') || '"]')
ELSE
json_extract(t.statement, '$.Action')
END AS action_fixed
FROM iam_policies
CROSS JOIN UNNEST(CAST(statement AS array(json))) AS t(statement)
),
Expand All @@ -130,12 +136,13 @@ bad_statements AS (
ps.account_id,
ps.arn AS resource_id,
CASE
WHEN JSON_EXTRACT_SCALAR(ps.statement, '$.Action') LIKE '%:*'
OR JSON_EXTRACT_SCALAR(ps.statement, '$.Action') = '*' THEN 1
WHEN action LIKE '%:*'
OR action = '*' THEN 1
ELSE 0
END AS status
FROM
policy_statements ps
policy_statements ps,
UNNEST(CAST(action_fixed as array(varchar))) t(action)
WHERE JSON_EXTRACT_SCALAR(ps.statement, '$.Effect') = 'Allow'
)
SELECT DISTINCT
Expand Down
57 changes: 37 additions & 20 deletions transformations/aws/macros/iam/policies_with_admin_rights.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,34 +132,51 @@ policy_statements AS (
id,
account_id,
arn,
t.statement
t.statement,
CASE
WHEN json_array_length(json_extract(t.statement, '$.Resource')) IS NULL THEN
json_parse('["' || json_extract_scalar(t.statement, '$.Resource') || '"]')
ELSE
json_extract(t.statement, '$.Resource')
END AS resource_fixed,
CASE
WHEN json_array_length(json_extract(t.statement, '$.Action')) IS NULL THEN
json_parse('["' || json_extract_scalar(t.statement, '$.Action') || '"]')
ELSE
json_extract(t.statement, '$.Action')
END AS action_fixed
FROM iam_policies
CROSS JOIN UNNEST(CAST(statement AS array(json))) AS t(statement)
),
allow_all_statements AS (
SELECT
id,
account_id,
arn
FROM policy_statements
WHERE (JSON_EXTRACT_SCALAR(statement, '$.Effect') = '"Allow"'
OR JSON_EXTRACT_SCALAR(statement, '$.Effect') = 'Allow')
AND (
JSON_EXTRACT_SCALAR(statement, '$.Action') = '*'
OR
JSON_EXTRACT_SCALAR(statement, '$.Action') LIKE '%"*"%'
)
AND
(
JSON_EXTRACT_SCALAR(statement, '$.Resource') = '*'
OR
JSON_EXTRACT_SCALAR(statement, '$.Resource') LIKE '%"*"%'
)

GROUP BY id, account_id, arn
arn,
CASE
WHEN json_array_length(json_extract(statement, '$.Resource')) IS NULL THEN
json_parse('["' || json_extract_scalar(statement, '$.Resource') || '"]')
ELSE
json_extract(statement, '$.Resource')
END AS resource_fixed,
CASE
WHEN json_array_length(json_extract(statement, '$.Action')) IS NULL THEN
json_parse('["' || json_extract_scalar(statement, '$.Action') || '"]')
ELSE
json_extract(statement, '$.Action')
END AS action_fixed
FROM policy_statements,
UNNEST(CAST(resource_fixed as array(varchar))) t(resource),
UNNEST(CAST(action_fixed as array(varchar))) t(action)
WHERE
((JSON_EXTRACT_SCALAR(statement, '$.Effect') = '"Allow"'
or JSON_EXTRACT_SCALAR(statement, '$.Effect') = 'Allow'))
AND
( action = '*' or action LIKE '%"*"%' )
AND
(resource = '*' or resource LIKE '%"*"%')
)

SELECT
SELECT distinct
'{{framework}}' AS framework,
'{{check_id}}' AS check_id,
'IAM policies should not allow full * administrative privileges' AS title,
Expand Down
Loading