Skip to content

v1.15.1

Compare
Choose a tag to compare
@cloudposse-releaser cloudposse-releaser released this 12 Dec 15:45
· 3 commits to refs/heads/main since this release
75cc76a

🚀 Enhancements

fix: reserved instances restrictions @oycyc (#244) ## what

This conditional check on whether or not to enable reserved instances is too restrictive. contains(["mysql", "postgresql"], local.reserved_instance_engine) is saying that only allow it if it is MySQL or PostgreSQL.

I think contains was originally meant to be like in the literal sense of "contains". Since in my case, I'm using aurora-postgresql, and it fails this check, yet it is one of the options for reserved instances.

why

endswith might be better, but it is TOO restrictive, seeing that there's so many options.
image
Additionally, Terraform will fail if user specifies the wrong engine type. There's no need for this check.

image

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/rds_reserved_instance_offering

🐛 Bug Fixes

fix: reserved instances restrictions @oycyc (#244) ## what

This conditional check on whether or not to enable reserved instances is too restrictive. contains(["mysql", "postgresql"], local.reserved_instance_engine) is saying that only allow it if it is MySQL or PostgreSQL.

I think contains was originally meant to be like in the literal sense of "contains". Since in my case, I'm using aurora-postgresql, and it fails this check, yet it is one of the options for reserved instances.

why

endswith might be better, but it is TOO restrictive, seeing that there's so many options.
image
Additionally, Terraform will fail if user specifies the wrong engine type. There's no need for this check.

image

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/rds_reserved_instance_offering