Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cloudsmith action 0.5.4 -> 0.6.10, new builder hosted by ghcr.io #4789

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jun 18, 2024

what

  • Update builder image host from Docker Hub to ghcr.io (and use new builder)
  • Update Cloudsmith action 0.5.4 -> 0.6.10
  • Do not automatically run package builder workflow on push to main if nothing has changed but the workflow file
  • Do not automatically run package builder workflow on PR if branch name starts with mass-update/

why

  • When mass-updating packages, we hit Docker Hub rate limits, but ghcr.io is more permissive (and better performing on GitHub-hosted runners).
  • Old Cloudsmith action ran in a Docker image, and we occasionally ran into issues with Docker-in-Docker. New action is just a Python executable, which works better, but requires us to pre-install Python, which we did in the new builders with Update build OSes, pre-install Python #4762.
  • Usually, changes to the workflow file are not relevant to the package itself, but are maintenance issues such as updating the action version. Avoid all the waste and overhead of rebuilding packages when nothing substantive has changed.
  • When updating a single package, allow the workflow to run, but provide a mechanism to update all the workflows without triggering runs, to avoid the massive unneeded workflow.

references

@Nuru Nuru requested a review from a team as a code owner June 18, 2024 22:06
@Nuru Nuru merged commit ab05ad3 into main Jun 18, 2024
2 checks passed
@Nuru Nuru deleted the mass-update/cloudsmith-action branch June 18, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant