Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add enum for format parameter #220

Merged
merged 2 commits into from
Oct 22, 2024
Merged

feat: Add enum for format parameter #220

merged 2 commits into from
Oct 22, 2024

Conversation

saai-syvendra
Copy link
Contributor

Description

Add a list of allowable strings as an enum type for the format parameter.

Issue Ticket Number

Fixes #142

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@colbyfayock colbyfayock merged commit 0ecd331 into cloudinary-community:main Oct 22, 2024
@colbyfayock
Copy link
Collaborator

this is great @saai-syvendra!

thanks for your contribution. this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at [email protected] with your name, GitHub username, and a link to the PR where I'll send further instructions.

Happy Hacktoberfest!

@colbyfayock
Copy link
Collaborator

@all-contributors please add @saai-syvendra for code

@allcontributors allcontributors bot mentioned this pull request Oct 22, 2024
Open
@allcontributors AllContributors
Copy link
Contributor

@colbyfayock

I've put up a pull request to add @saai-syvendra! 🎉

github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
@semantic-release-bot
chore(release): 5.10.6 [skip ci]
e34fd5a 
# [@cloudinary-util/url-loader-v5.10.6](https://github.com/cloudinary-community/cloudinary-util/compare/@cloudinary-util/url-loader-v5.10.5...@cloudinary-util/url-loader-v5.10.6) (2024-10-22)

### Bug Fixes

* Add enum for format parameter ([#220](#220)) ([0ecd331](0ecd331)), closes [#142](#142)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @cloudinary-util/url-loader-v5.10.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
@semantic-release-bot
chore(release): 6.0.0-beta.2 [skip ci]
e0b1bef 
# [@cloudinary-util/url-loader-v6.0.0-beta.2](https://github.com/cloudinary-community/cloudinary-util/compare/@cloudinary-util/url-loader-v6.0.0-beta.1...@cloudinary-util/url-loader-v6.0.0-beta.2) (2024-10-22)

### Bug Fixes

* Add enum for format parameter ([#220](#220)) ([0ecd331](0ecd331)), closes [#142](#142)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @cloudinary-util/url-loader-v6.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add enum for format parameter
2 participants
@saai-syvendra @colbyfayock