Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: laravel-image-upload #84

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

AvaterClasher
Copy link
Contributor

@AvaterClasher AvaterClasher commented Oct 6, 2023

closes [#46 ]
Added the laravel image upload widget.

@colbyfayock
Copy link
Collaborator

got it working! had to install php and composer 😂

guessing a lot of the files comes with a default installation of Laravel? like the auth stuff?

also curious, are all of the other lines in FileUploadController just different options for the Laravel SDK and uploading files?

@AvaterClasher
Copy link
Contributor Author

AvaterClasher commented Oct 7, 2023

Yeah it does come with a lot of boilerplate. Its a pain too manage versions of php and laravel too. As laravel does not support php 8 till now. Yeah they are different uploading options. Also can you please read your discord dm's @colbyfayock

@colbyfayock
Copy link
Collaborator

2 requests:

  • can we remove the folder name you have there? alarmanda
  • can you show the resulting image on the upload result page rather than just the path?

after that lets get this merged!

@AvaterClasher
Copy link
Contributor Author

@colbyfayock The thing is i can try to do it but when i was installing meteor yesterday it messed up all my system environment variables so none of the commands like php, composer, code . , go etc. nothing works . I am trying to fix it. So if you are okay you might have to wait a bit. Sorry 😔.

@vercel
Copy link

vercel bot commented Oct 13, 2023

@colbyfayock is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

@colbyfayock
Copy link
Collaborator

hey @AvaterClasher made a few tweaks, im going to merge this in and open a separate ticket to update it. if you find the time and get the enviornment back up and running that would be great to get the fixes in! but for now, let's unblock this as it still provides some value

@colbyfayock colbyfayock merged commit 95bc1d2 into cloudinary-community:main Oct 13, 2023
@colbyfayock
Copy link
Collaborator

@all-contributors please add @AvaterClasher for code

@allcontributors
Copy link
Contributor

@colbyfayock

I've put up a pull request to add @AvaterClasher! 🎉

@colbyfayock
Copy link
Collaborator

@AvaterClasher i can't remember if you've completed a separate PR for hacktoberfest yet already or still working on others, but in case you didn't, congrats on the merged PR! since it was merged during Hacktoberfest, you're eligible for some free swag. Please email [email protected] with your Github username and a link to this PR where we'll follow up with you there.

https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks

disclaimer since you're working on multiple: everyone is only eligble for 1 swag pack

@colbyfayock
Copy link
Collaborator

Issue created here: #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants