Improve some integration-tests and cleanup /v2/info endpoint. fix #1229 #1249 #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lokowandtg
changed the title
|
Hey we've disabled V2 in our env in preparation for the V2 API deprecation which is scheduled for this month I think. Think we need these changes merging in so we can exclusively use the v3 apis |
|
I totally agree. Who can do the review and merge? |
|
@anthonydahanne what do you think of the proposed changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls to /v2/info endpoint with calls to root endpoint of API version 3.
Skip integration tests that depend on routing if server does not provide it.