-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(c3): update Next version in the experimental template #7743
Conversation
🦋 Changeset detectedLatest commit: b5f166d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-wrangler-7743 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7743/npm-package-wrangler-7743 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-wrangler-7743 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workers-bindings-extension-7743 -O ./cloudflare-workers-bindings-extension.0.0.0-v8989e98b4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8989e98b4.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-create-cloudflare-7743 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-kv-asset-handler-7743 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-miniflare-7743 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-pages-shared-7743 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-unenv-preset-7743 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-vitest-pool-workers-7743 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workers-editor-shared-7743 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workers-shared-7743 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workflows-shared-7743 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@vicb quick note, I think that this PR does not need the I noticed that the C3 e2es are run anyways and not included into what the PR description and label considers e2es For example you can see Samuel skipping them in his C3 PRs: #7676, #7390 Maybe we should make this clear (since I as well didn't realize this for quite a while): #7744 |
I often add e2e as a safety net. It seems like some e2e are failing after we switched to generating |
Fixed #7745 |
Do not pin
create-next-app
to a specific version but usecreate-next-app@^14.2.23
to get the latest 14 version.Renamed the
wrangler types
output fromend.d.ts
tocloudflare-env.d.ts
. This is to help clarify that it is not related to.env*
files. Next also generates anext-env.d.ts
in the root folder.Loosely related to opennextjs/opennextjs-cloudflare#238 (will document the new file name when/if this gets merged)