Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(c3): update Next version in the experimental template #7743

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 13, 2025

Do not pin create-next-app to a specific version but use create-next-app@^14.2.23 to get the latest 14 version.

Renamed the wrangler types output from end.d.ts to cloudflare-env.d.ts. This is to help clarify that it is not related to .env* files. Next also generates a next-env.d.ts in the root folder.

Loosely related to opennextjs/opennextjs-cloudflare#238 (will document the new file name when/if this gets merged)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tested locally
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: will be documented on the OpenNext repo

@vicb vicb requested review from a team as code owners January 13, 2025 07:48
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: b5f166d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb added the e2e Run e2e tests on a PR label Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-wrangler-7743

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7743/npm-package-wrangler-7743

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-wrangler-7743 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workers-bindings-extension-7743 -O ./cloudflare-workers-bindings-extension.0.0.0-v8989e98b4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8989e98b4.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-create-cloudflare-7743 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-kv-asset-handler-7743

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-miniflare-7743

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-pages-shared-7743

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-unenv-preset-7743

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-vitest-pool-workers-7743

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workers-editor-shared-7743

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workers-shared-7743

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748886982/npm-package-cloudflare-workflows-shared-7743

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Jan 13, 2025

@vicb quick note, I think that this PR does not need the e2e label (and the relative checkbox in the PR description)

I noticed that the C3 e2es are run anyways and not included into what the PR description and label considers e2es

For example you can see Samuel skipping them in his C3 PRs: #7676, #7390

Maybe we should make this clear (since I as well didn't realize this for quite a while): #7744

@vicb
Copy link
Contributor Author

vicb commented Jan 13, 2025

I often add e2e as a safety net.

It seems like some e2e are failing after we switched to generating wrangler.json. I'll rebase the PR once this is fixed.

@petebacondarwin
Copy link
Contributor

It seems like some e2e are failing after we switched to generating wrangler.json. I'll rebase the PR once this is fixed.

Fixed #7745

@vicb vicb changed the title c3x-next chore(c3): update Next version in the experimental template Jan 13, 2025
@vicb vicb merged commit 5955dac into main Jan 13, 2025
31 checks passed
@vicb vicb deleted the c3x-next branch January 13, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants