Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style Guide] Document using JSX in partials #19369

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

Conversation

KianNH
Copy link
Contributor

@KianNH KianNH commented Jan 22, 2025

Summary

Documents using JSX in partials

@KianNH KianNH requested review from dcpena and a team as code owners January 22, 2025 21:49
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0eb97b9
Status: ✅  Deploy successful!
Preview URL: https://5877ba81.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://kian-pcx-5636.cloudflare-docs-7ou.pages.dev

View logs

Copy link

@pedrosousa
Copy link
Contributor

Hi Kian! A couple of requests:

  • Can we expand the example a bit more? Not everyone in the team is well versed in JSX and how to create these optional blocks from start to finish. Even if we need to repeat ourselves a bit with content already covered in other pages... If the example also covered the use of the Markdown component it would be great!
  • Can we add an if/then/else example, probably using a condition ? true : false conditional?

IreneSAvila

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants