Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages x Node.js => OpenNext #17123

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Pages x Node.js => OpenNext #17123

merged 2 commits into from
Sep 26, 2024

Conversation

irvinebroque
Copy link
Contributor

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b07cc2
Status: ✅  Deploy successful!
Preview URL: https://972c42b8.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://bib-opennext.cloudflare-docs-7ou.pages.dev

View logs

@irvinebroque irvinebroque requested a review from a team September 26, 2024 09:33
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

@@ -13,6 +13,12 @@ import { PackageManagers } from "~/components";

Learn how to deploy full-stack (SSR) Next.js apps to Cloudflare Pages.

:::note
You can now also deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/frameworks/), including apps that use the Node.js "runtime" from Next.js. This allows you to use the [Node.js APIs that Cloudflare Workers provides](/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis), and ensures compatibility with a broader set of Next.js features and rendering modes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can now also deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/frameworks/), including apps that use the Node.js "runtime" from Next.js. This allows you to use the [Node.js APIs that Cloudflare Workers provides](/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis), and ensures compatibility with a broader set of Next.js features and rendering modes.
You can now also deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/frameworks/), including apps that use the Node.js "runtime" from Next.js. This allows you to use the [Node.js APIs that Cloudflare Workers provides](/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis), and ensures compatibility with a broader set of Next.js features and rendering modes.

Issues:

  • Style Guide - (Terms-error) Use 'Cloudflare' instead of 'cloudflare'.

Fix Explanation:

The only issue identified is the capitalization of 'Cloudflare'. The correction involves capitalizing 'Cloudflare' to adhere to the style guide. The rest of the sentence is clear and does not require any additional changes. If the style guide is updated or if there are other terms that need to be checked, further review might be necessary.

@@ -13,6 +13,12 @@ import { PackageManagers } from "~/components";

Learn how to deploy full-stack (SSR) Next.js apps to Cloudflare Pages.

:::note
You can now also deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/frameworks/), including apps that use the Node.js "runtime" from Next.js. This allows you to use the [Node.js APIs that Cloudflare Workers provides](/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis), and ensures compatibility with a broader set of Next.js features and rendering modes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can now also deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/frameworks/), including apps that use the Node.js "runtime" from Next.js. This allows you to use the [Node.js APIs that Cloudflare Workers provides](/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis), and ensures compatibility with a broader set of Next.js features and rendering modes.
You can also deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/frameworks/), including apps that use the Node.js "runtime" from Next.js. This allows you to use the [Node.js APIs that Cloudflare Workers provides](/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis), and ensures compatibility with a broader set of Next.js features and rendering modes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just found that terms like "now" or announcement language tends to age poorly if they're not updated often and I confirmed with another TW that we steer away from that.

:::note
You can now also deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/frameworks/), including apps that use the Node.js "runtime" from Next.js. This allows you to use the [Node.js APIs that Cloudflare Workers provides](/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis), and ensures compatibility with a broader set of Next.js features and rendering modes.

Refer to the [OpenNext docs for the `@opennextjs/cloudflare` adapter](https://opennext.js.org/cloudflare) to learn how to get started.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Refer to the [OpenNext docs for the `@opennextjs/cloudflare` adapter](https://opennext.js.org/cloudflare) to learn how to get started.
Learn how to get started in the [OpenNext documentation for the `@opennextjs/cloudflare` adapter] (https://opennext.js.org/cloudflare)

@irvinebroque irvinebroque merged commit 23067b3 into production Sep 26, 2024
13 of 14 checks passed
@irvinebroque irvinebroque deleted the bib/opennext branch September 26, 2024 13:57
patriciasantaana pushed a commit that referenced this pull request Sep 26, 2024
* Pages x Node.js => OpenNext

refs opennextjs/docs#3

* Update src/content/docs/pages/framework-guides/nextjs/ssr/get-started.mdx

Co-authored-by: Tanushree <[email protected]>

---------

Co-authored-by: Tanushree <[email protected]>
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* Pages x Node.js => OpenNext

refs opennextjs/docs#3

* Update src/content/docs/pages/framework-guides/nextjs/ssr/get-started.mdx

Co-authored-by: Tanushree <[email protected]>

---------

Co-authored-by: Tanushree <[email protected]>
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
* Pages x Node.js => OpenNext

refs opennextjs/docs#3

* Update src/content/docs/pages/framework-guides/nextjs/ssr/get-started.mdx

Co-authored-by: Tanushree <[email protected]>

---------

Co-authored-by: Tanushree <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants