Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 🚀 Feature snapshot identifier argument and did minor changes #67

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Feat: 🚀 Feature snapshot identifier argument and did minor changes #67

merged 1 commit into from
Mar 1, 2024

Conversation

nileshgadgi
Copy link
Member

what

  • Introduced snapshot identifier argument for the parameter group and Elasticache cluster.
  • Updated variables to use a map for parameter group and route53 argument.
  • Added var.enable condition in all resource condition to not create resources if enable variable is set to false.
  • Updated output file to prevent error while enable variables is set to false.

why

  • One issue was raised for this feature. link

@nileshgadgi nileshgadgi added the enhancement New feature or request label Feb 26, 2024
@nileshgadgi nileshgadgi self-assigned this Feb 26, 2024
vaibhav7797
vaibhav7797 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

themaniskshah
themaniskshah approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit 999adf2 into master Mar 1, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/issue-66 branch March 1, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themaniskshah themaniskshah themaniskshah approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@nileshgadgi nileshgadgi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nileshgadgi @themaniskshah @vaibhav7797 @clouddrove-ci