Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use public ECR rather than dockerhub for ubuntu image #4

Merged
merged 2 commits into from
Oct 28, 2024
Merged

use public ECR rather than dockerhub for ubuntu image #4

merged 2 commits into from
Oct 28, 2024

Conversation

dandersonsw
Copy link
Contributor

Changes proposed in this pull request:

  • Updates the pipeline to grab the public ubuntu image from ECR rather than Dockerhub
  • I compared the images and they are exactly the same

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Downloads ubuntu image from public ECR rather than Dockerhub

@dandersonsw dandersonsw requested a review from a team as a code owner October 23, 2024 18:48
@dandersonsw dandersonsw merged commit e7d73d7 into main Oct 28, 2024
@dandersonsw dandersonsw deleted the update-source branch October 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshochadel jameshochadel jameshochadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandersonsw @jameshochadel